Fix Flipper lints #2

Summary: Per title.

Reviewed By: timur-valiev

Differential Revision: D30843077

fbshipit-source-id: 1a3f4757518610b8caf41c62af7e27723d0de8d6

desktop/app/src/dispatcher/__tests__/plugins.node.tsx

@@ -18,8 +18,9 @@ import dispatcher, {
 } from '../plugins';
 import {BundledPluginDetails, InstalledPluginDetails} from 'flipper-plugin-lib';
 import path from 'path';
+// Allowed in a test.
+// eslint-disable-next-line flipper/no-electron-remote-imports
 import {remote} from 'electron';
-import {FlipperPlugin} from '../../plugin';
 import {createRootReducer, State} from '../../reducers/index';
 import {getInstance} from '../../fb-stubs/Logger';
 import configureStore from 'redux-mock-store';

desktop/app/src/dispatcher/application.tsx

@@ -7,6 +7,8 @@
  * @format
  */
 
+// Fine for app startup.
+// eslint-disable-next-line flipper/no-electron-remote-imports
 import {remote, ipcRenderer, IpcRendererEvent} from 'electron';
 import {Store} from '../reducers/index';
 import {Logger} from '../fb-interfaces/Logger';

desktop/app/src/dispatcher/flipperServer.tsx

@@ -155,6 +155,7 @@ export async function handleClientConnected(store: Store, client: Client) {
     payload: client,
   });
 
+  // eslint-disable-next-line node/no-sync
   const device = client.deviceSync;
   if (device) {
     store.dispatch(selectDevice(device));

desktop/app/src/dispatcher/index.tsx

@@ -7,6 +7,8 @@
  * @format
  */
 
+// Used responsibly.
+// eslint-disable-next-line flipper/no-electron-remote-imports
 import {remote} from 'electron';
 import flipperServer from './flipperServer';
 import application from './application';

desktop/app/src/dispatcher/pluginDownloads.tsx

@@ -86,10 +86,8 @@ async function handlePluginDownload(
   const tmpFile = path.join(tmpDir, `${name}-${version}.tgz`);
   let installedPlugin: InstalledPluginDetails | undefined;
   try {
-    const cancellationSource = axios.CancelToken.source();
+    const cancelationSource = axios.CancelToken.source();
-    dispatch(
+    dispatch(pluginDownloadStarted({plugin, cancel: cancelationSource.cancel}));
-      pluginDownloadStarted({plugin, cancel: cancellationSource.cancel}),
-    );
     if (await fs.pathExists(installationDir)) {
       console.log(
         `Using existing files instead of downloading plugin "${title}" v${version} from "${downloadUrl}" to "${installationDir}"`,
@@ -100,7 +98,7 @@ async function handlePluginDownload(
       let percentCompleted = 0;
       const response = await axios.get(plugin.downloadUrl, {
         adapter: axiosHttpAdapter,
-        cancelToken: cancellationSource.token,
+        cancelToken: cancelationSource.token,
         responseType: 'stream',
         headers: {
           'Sec-Fetch-Site': 'none',

desktop/app/src/dispatcher/pluginManager.tsx

@@ -51,13 +51,11 @@ import {getPluginKey} from '../utils/pluginKey';
 
 const maxInstalledPluginVersionsToKeep = 2;
 
-function refreshInstalledPlugins(store: Store) {
+async function refreshInstalledPlugins(store: Store) {
-  removePlugins(store.getState().plugins.uninstalledPluginNames.values())
+  await removePlugins(store.getState().plugins.uninstalledPluginNames.values());
-    .then(() =>
+  await cleanupOldInstalledPluginVersions(maxInstalledPluginVersionsToKeep);
-      cleanupOldInstalledPluginVersions(maxInstalledPluginVersionsToKeep),
+  const plugins = await getInstalledPlugins();
-    )
+  return store.dispatch(registerInstalledPlugins(plugins));
-    .then(() => getInstalledPlugins())
-    .then((plugins) => store.dispatch(registerInstalledPlugins(plugins)));
 }
 
 export default (
@@ -70,7 +68,9 @@ export default (
   // This needn't happen immediately and is (light) I/O work.
   if (window.requestIdleCallback) {
     window.requestIdleCallback(() => {
-      refreshInstalledPlugins(store);
+      refreshInstalledPlugins(store).catch((err) =>
+        console.error('Failed to refresh installed plugins:', err),
+      );
     });
   }
 

desktop/app/src/dispatcher/reactNative.tsx

@@ -7,6 +7,8 @@
  * @format
  */
 
+// Used to register a shortcut. Don't have an alternative for that.
+// eslint-disable-next-line flipper/no-electron-remote-imports
 import {remote} from 'electron';
 import MetroDevice from '../server/devices/metro/MetroDevice';
 import {Store} from '../reducers';

desktop/app/src/dispatcher/tracking.tsx

@@ -7,6 +7,8 @@
  * @format
  */
 
+// Used for PID tracking.
+// eslint-disable-next-line flipper/no-electron-remote-imports
 import {ipcRenderer, remote} from 'electron';
 import {performance} from 'perf_hooks';
 import {EventEmitter} from 'events';