From 1b3e3468a3059c103e83591bb5c4b6012aa0feca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20B=C3=BCchele?= <danielbuechele@fb.com>
Date: Mon, 6 Aug 2018 06:19:28 -0700
Subject: [PATCH] fix scrollbars in logs

Summary: Some columns in logs plugin where showing scrollbars since the update to electron 3. This hides scrollbars on all columns

Reviewed By: passy

Differential Revision: D9179242

fbshipit-source-id: bdf2e1a6f77d2a7e25cb34792b980afe7571e643
---
 src/device-plugins/logs/index.js | 25 +++++++++++--------------
 1 file changed, 11 insertions(+), 14 deletions(-)

diff --git a/src/device-plugins/logs/index.js b/src/device-plugins/logs/index.js
index 27e79930e..8f323d212 100644
--- a/src/device-plugins/logs/index.js
+++ b/src/device-plugins/logs/index.js
@@ -201,14 +201,17 @@ const DEFAULT_FILTERS = [
   },
 ];
 
-const NonSelectableText = Text.extends({
+const HiddenScrollText = Text.extends({
   alignSelf: 'baseline',
   userSelect: 'none',
   lineHeight: '130%',
   marginTop: 6,
+  '&::-webkit-scrollbar': {
+    display: 'none',
+  },
 });
 
-const LogCount = NonSelectableText.extends(
+const LogCount = HiddenScrollText.extends(
   {
     backgroundColor: props => props.color,
     borderRadius: '999em',
@@ -226,12 +229,6 @@ const LogCount = NonSelectableText.extends(
   },
 );
 
-const HiddenScrollText = NonSelectableText.extends({
-  '&::-webkit-scrollbar': {
-    display: 'none',
-  },
-});
-
 function pad(chunk: mixed, len: number): string {
   let str = String(chunk);
   while (str.length < len) {
@@ -343,29 +340,29 @@ export default class LogTable extends SonarDevicePlugin<LogsState> {
             },
             tag: {
               value: (
-                <NonSelectableText code={true}>{entry.tag}</NonSelectableText>
+                <HiddenScrollText code={true}>{entry.tag}</HiddenScrollText>
               ),
               isFilterable: true,
             },
             pid: {
               value: (
-                <NonSelectableText code={true}>
+                <HiddenScrollText code={true}>
                   {String(entry.pid)}
-                </NonSelectableText>
+                </HiddenScrollText>
               ),
               isFilterable: true,
             },
             tid: {
               value: (
-                <NonSelectableText code={true}>
+                <HiddenScrollText code={true}>
                   {String(entry.tid)}
-                </NonSelectableText>
+                </HiddenScrollText>
               ),
               isFilterable: true,
             },
             app: {
               value: (
-                <NonSelectableText code={true}>{entry.app}</NonSelectableText>
+                <HiddenScrollText code={true}>{entry.app}</HiddenScrollText>
               ),
               isFilterable: true,
             },