diff --git a/desktop/.eslintrc.js b/desktop/.eslintrc.js index 065b4e82c..eb9cee073 100644 --- a/desktop/.eslintrc.js +++ b/desktop/.eslintrc.js @@ -189,6 +189,14 @@ module.exports = { caughtErrorsIgnorePattern: '^_', }, ], + '@typescript-eslint/naming-convention': [ + 2, + { + selector: 'typeLike', + format: ['PascalCase', 'UPPER_CASE'], + leadingUnderscore: 'allow', + }, + ], }, }, { diff --git a/desktop/flipper-server-core/src/devices/ios/iOSCrashUtils.tsx b/desktop/flipper-server-core/src/devices/ios/iOSCrashUtils.tsx index f63b1cdf1..4160accae 100644 --- a/desktop/flipper-server-core/src/devices/ios/iOSCrashUtils.tsx +++ b/desktop/flipper-server-core/src/devices/ios/iOSCrashUtils.tsx @@ -64,6 +64,7 @@ export function parsePath(content: string): string | null { return path.trim(); } +// eslint-disable-next-line @typescript-eslint/naming-convention export class iOSCrashWatcher extends DeviceListener { constructor(private readonly device: ServerDevice) { super(() => device.connected); diff --git a/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx b/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx index 52728065c..b4879b0c2 100644 --- a/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx +++ b/desktop/flipper-server-core/src/devices/ios/iOSDeviceManager.tsx @@ -25,6 +25,7 @@ import {getFlipperServerConfig} from '../../FlipperServerConfig'; import {IdbConfig, setIdbConfig} from './idbConfig'; import {assertNotNull} from 'flipper-server-core/src/comms/Utilities'; +// eslint-disable-next-line @typescript-eslint/naming-convention type iOSSimulatorDevice = { state: 'Booted' | 'Shutdown' | 'Shutting Down'; availability?: string; diff --git a/desktop/flipper-server-core/src/devices/ios/iOSLogListener.tsx b/desktop/flipper-server-core/src/devices/ios/iOSLogListener.tsx index aba93ddac..43db00f64 100644 --- a/desktop/flipper-server-core/src/devices/ios/iOSLogListener.tsx +++ b/desktop/flipper-server-core/src/devices/ios/iOSLogListener.tsx @@ -61,6 +61,7 @@ type RawLogEntry = { // Mar 25 17:06:38 iPhone symptomsd(SymptomEvaluator)[125] : Stuff const logRegex = /(^.{15}) ([^ ]+?) ([^\[]+?)\[(\d+?)\] <(\w+?)>: (.*)$/s; +// eslint-disable-next-line @typescript-eslint/naming-convention export class iOSLogListener extends DeviceListener { constructor( isDeviceConnected: () => boolean, diff --git a/docs/extending/dev-setup.mdx b/docs/extending/dev-setup.mdx index 1ddb378b3..55f9dc18d 100644 --- a/docs/extending/dev-setup.mdx +++ b/docs/extending/dev-setup.mdx @@ -160,7 +160,6 @@ To start Flipper against a specific OnDemand instance, set FB_ONDEMAND flag, e.g ## Guidelines for writing TypeScript * Prefer `type` for React props and state over interfaces * Don’t prefix interfaces with `I` -* Enums, Types and Interfaces use PascalCase (uppercase first letter) * Install 3rd party type definitions as dev dependency (e.g. `yarn add @types/lodash --dev`) ## Submitting a diff / PR