jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add error logging to client Id construction

Browse Source 
Summary: Just in case anything is broken, this will be helpful

Reviewed By: nikoant

Differential Revision: D18811849

fbshipit-source-id: 53947102dea38e526b4f565396f85fedf4ff2a15
This commit is contained in:
John Knox
2019-12-05 05:35:35 -08:00
committed by Facebook Github Bot
parent d4acdf8504
commit 186af77f62
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/utils/clientUtils.tsx
View File

@@ -10,7 +10,7 @@
import Client from '../Client'; import Client from '../Client';
import BaseDevice from '../devices/BaseDevice'; import BaseDevice from '../devices/BaseDevice';
type ClientIdConstituents = { export type ClientIdConstituents = {
app: string; app: string;
os: string; os: string;
device: string; device: string;
@@ -40,6 +40,15 @@ export function buildClientId(clientInfo: {
device: string; device: string;
device_id: string; device_id: string;
}): string { }): string {
for (const key of ['app', 'os', 'device', 'device_id'] as Array<
keyof ClientIdConstituents
>) {
if (!clientInfo[key]) {
console.error(
`Attempted to build clientId with invalid ${key}: "${clientInfo[key]}`,
);
}
}
return `${clientInfo.app}#${clientInfo.os}#${clientInfo.device}#${clientInfo.device_id}`; return `${clientInfo.app}#${clientInfo.os}#${clientInfo.device}#${clientInfo.device_id}`;
} }