Open connectivity troubleshoot if unable to find device
Summary: If the notification is shown, allow engineers to switch to the connectivity troubleshooting view as it may highlight where the problem is. Reviewed By: antonk52 Differential Revision: D47869154 fbshipit-source-id: f4154bb230d891dc4ac108b5acbe7e6541ffed1a
This commit is contained in:
committed by
Facebook GitHub Bot
parent
7cb91807d3
commit
176301979a
@@ -18,13 +18,17 @@ import {
|
|||||||
FlipperServerState,
|
FlipperServerState,
|
||||||
} from 'flipper-common';
|
} from 'flipper-common';
|
||||||
import Client from '../Client';
|
import Client from '../Client';
|
||||||
import {notification} from 'antd';
|
import {Button, notification} from 'antd';
|
||||||
import {BaseDevice} from 'flipper-frontend-core';
|
import {BaseDevice} from 'flipper-frontend-core';
|
||||||
import {ClientDescription, timeout} from 'flipper-common';
|
import {ClientDescription, timeout} from 'flipper-common';
|
||||||
import {reportPlatformFailures} from 'flipper-common';
|
import {reportPlatformFailures} from 'flipper-common';
|
||||||
import {sideEffect} from '../utils/sideEffect';
|
import {sideEffect} from '../utils/sideEffect';
|
||||||
import {waitFor} from '../utils/waitFor';
|
import {waitFor} from '../utils/waitFor';
|
||||||
import {NotificationBody} from '../ui/components/NotificationBody';
|
import {NotificationBody} from '../ui/components/NotificationBody';
|
||||||
|
import {Layout} from '../ui';
|
||||||
|
import {setStaticView} from '../reducers/connections';
|
||||||
|
import {ConnectivityHub} from '../chrome/ConnectivityHub';
|
||||||
|
import {setTopLevelSelection} from '../reducers/application';
|
||||||
|
|
||||||
export function connectFlipperServerToStore(
|
export function connectFlipperServerToStore(
|
||||||
server: FlipperServer,
|
server: FlipperServer,
|
||||||
@@ -307,10 +311,30 @@ export async function handleClientConnected(
|
|||||||
`[conn] Failed to find device '${query.device_id}' while connection app '${query.app}'`,
|
`[conn] Failed to find device '${query.device_id}' while connection app '${query.app}'`,
|
||||||
e,
|
e,
|
||||||
);
|
);
|
||||||
|
const key = `device-find-failure-${query.device_id}`;
|
||||||
notification.error({
|
notification.error({
|
||||||
key: `device-find-failure-${query.device_id}`,
|
key,
|
||||||
message: 'Connection failed',
|
message: 'Connection failed',
|
||||||
description: `Failed to find device '${query.device_id}' while trying to connect app '${query.app}'`,
|
description: (
|
||||||
|
<Layout.Bottom>
|
||||||
|
<p>
|
||||||
|
Failed to find device '{query.device_id}' while trying to
|
||||||
|
connect app '{query.app}'`
|
||||||
|
</p>
|
||||||
|
<div>
|
||||||
|
<Button
|
||||||
|
type="primary"
|
||||||
|
style={{float: 'right'}}
|
||||||
|
onClick={() => {
|
||||||
|
store.dispatch(setTopLevelSelection('connectivity'));
|
||||||
|
store.dispatch(setStaticView(ConnectivityHub));
|
||||||
|
notification.close(key);
|
||||||
|
}}>
|
||||||
|
Troubleshoot
|
||||||
|
</Button>
|
||||||
|
</div>
|
||||||
|
</Layout.Bottom>
|
||||||
|
),
|
||||||
duration: 0,
|
duration: 0,
|
||||||
});
|
});
|
||||||
},
|
},
|
||||||
|
|||||||
Reference in New Issue
Block a user