From 14b83ad050937f6d85e78d651ca142053f8fe21b Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Tue, 10 May 2022 08:45:57 -0700 Subject: [PATCH] Don't tear down server on disconnect Summary: These safeguards were added based on a discussion in D35088208 (https://github.com/facebook/flipper/commit/56e94394ca2f51be57818ec8f5d8663e6f626178) but turned out to be counter-productive. Every time a client disconnects now, we're tearing down the socket and the server, allowing for no future connections. Reviewed By: lblasa Differential Revision: D36252605 fbshipit-source-id: c3b6f85dea4054505a47d24a72a4aac403371c0f --- desktop/flipper-server/src/startBaseServer.tsx | 9 --------- 1 file changed, 9 deletions(-) diff --git a/desktop/flipper-server/src/startBaseServer.tsx b/desktop/flipper-server/src/startBaseServer.tsx index 33184328f..485b19bcf 100644 --- a/desktop/flipper-server/src/startBaseServer.tsx +++ b/desktop/flipper-server/src/startBaseServer.tsx @@ -161,15 +161,6 @@ async function startProxyServer( res.end('Failed to proxy request: ' + err); }); - proxyServer.on('close', () => { - server.close(); - }); - - server.on('close', () => { - proxyServer.close(); - fs.remove(socketPath); - }); - return new Promise((resolve) => { proxyServer.listen(config.port); server.listen(socketPath, undefined, () => resolve({app, server}));