Move configuration to module

Summary:
Moves the JSON config access to one module instead of
ad-hoc de-serialising the object all over the place.
This also adds a type for it so we hopefully won't typo things that easily.

Reviewed By: danielbuechele

Differential Revision: D13956612

fbshipit-source-id: 48098deafedf18cc86c8802a3c40fba9394b8262
This commit is contained in:
Pascal Hartig
2019-02-06 03:15:41 -08:00
committed by Facebook Github Bot
parent e78bd57514
commit 14ae2fea2c
4 changed files with 89 additions and 13 deletions

View File

@@ -24,6 +24,7 @@ import GK from '../fb-stubs/GK';
import {FlipperBasePlugin} from '../plugin.js';
import {setupMenuBar} from '../MenuBar.js';
import path from 'path';
import {default as config} from '../utils/processConfig.js';
export type PluginDefinition = {
name: string,
@@ -129,11 +130,7 @@ export const checkDisabled = (disabledPlugins: Array<PluginDefinition>) => (
): boolean => {
let disabledList: Set<string> = new Set();
try {
disabledList = new Set(
// $FlowFixMe process.env not defined in electron API spec
JSON.parse(remote?.process.env.CONFIG || process.env.CONFIG || '{}')
.disabledPlugins || [],
);
disabledList = config().disabledPlugins;
} catch (e) {
console.error(e);
}