From 146a5cf66659602a19085762453c449a65d0d49d Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Thu, 8 Jun 2023 11:03:44 -0700 Subject: [PATCH] Move server started analytics Summary: This is a better place as it takes place once the server starts listening. Reviewed By: passy Differential Revision: D46558350 fbshipit-source-id: f586defecc8e16d8f0b285615803662d8b6b75fb --- desktop/flipper-server-core/src/server/startServer.tsx | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/desktop/flipper-server-core/src/server/startServer.tsx b/desktop/flipper-server-core/src/server/startServer.tsx index f53bb5d67..18aa6be2e 100644 --- a/desktop/flipper-server-core/src/server/startServer.tsx +++ b/desktop/flipper-server-core/src/server/startServer.tsx @@ -223,10 +223,12 @@ async function startProxyServer( attachSocketServer(socket, serverImpl, companionEnv); return new Promise((resolve) => { proxyServer?.listen(config.port); - server.listen(socketPath, undefined, () => resolve()); - tracker.track('server-started', { - port: config.port, - tcp: config.tcp, + server.listen(socketPath, undefined, () => { + tracker.track('server-started', { + port: config.port, + tcp: config.tcp, + }); + resolve(); }); }); };