Cmd failures should be displayed as errors too

Summary:
Styles are applied depending on entry type. This was an issue when we had 'cmd' as a type too.

So, let's simplify and keep type to denote info, warning, or errors.

Later on we can add a different tag if we want to differentiate between logs, command, others.

Reviewed By: passy

Differential Revision: D47912857

fbshipit-source-id: 213a0768a95f63cbd692ba96f6745ab740346a58

desktop/flipper-common/src/server-types.tsx

@@ -78,7 +78,7 @@ export type DeviceLogLevel =
 
 export type ConnectionRecordEntry = {
   time: Date;
-  type: 'cmd' | 'info' | 'error';
+  type: 'warning' | 'info' | 'error';
   device: string;
   app: string;
   message: string;

desktop/flipper-server-core/src/recorder.tsx

@@ -42,7 +42,7 @@ class Recorder {
 
         const entry: CommandRecordEntry = {
           time: new Date(),
-          type: 'cmd',
+          type: payload.success ? 'info' : 'error',
           device,
           app,
           message: payload.cmd,