From 143dce85f1fd06cdbe1ba4deed3812b0662c0d35 Mon Sep 17 00:00:00 2001
From: Andrey Goncharov <aigoncharov@meta.com>
Date: Wed, 30 Aug 2023 07:26:35 -0700
Subject: [PATCH] Support integer operator type

Summary: Project doc: https://docs.google.com/document/d/1miofxds9DJgWScj0zFyBbdpRH5Rj0T9FqiCapof5-vU

Reviewed By: lblasa

Differential Revision: D48605154

fbshipit-source-id: 4662b61b217568e593f6b65c8b4dd1d99ea5606a
---
 .../ui/PowerSearch/PowerSearchIntegerTerm.tsx | 56 +++++++++++++++++++
 .../src/ui/PowerSearch/PowerSearchTerm.tsx    | 48 +++++++++++++---
 2 files changed, 96 insertions(+), 8 deletions(-)
 create mode 100644 desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchIntegerTerm.tsx

diff --git a/desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchIntegerTerm.tsx b/desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchIntegerTerm.tsx
new file mode 100644
index 000000000..96757e3e9
--- /dev/null
+++ b/desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchIntegerTerm.tsx
@@ -0,0 +1,56 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @format
+ */
+
+import {Input} from 'antd';
+import React from 'react';
+
+type PowerSearchIntegerTermProps = {
+  onCancel: () => void;
+  onChange: (value: number) => void;
+};
+
+export const PowerSearchIntegerTerm: React.FC<PowerSearchIntegerTermProps> = ({
+  onCancel,
+  onChange,
+}) => {
+  return (
+    <Input
+      autoFocus
+      style={{width: 100}}
+      placeholder="..."
+      onChange={(event) => {
+        const newValue = event.target.value;
+
+        const normalizedValue = parseInt(newValue, 10);
+
+        if (normalizedValue.toString() !== newValue) {
+          event.target.value = normalizedValue.toString();
+        }
+      }}
+      onBlur={(event) => {
+        const newValue = event.target.value;
+
+        if (!newValue) {
+          onCancel();
+          return;
+        }
+
+        const normalizedValue = parseInt(newValue, 10);
+        onChange(normalizedValue);
+      }}
+      onKeyDown={(event) => {
+        if (event.key === 'Enter' || event.key === 'Escape') {
+          event.currentTarget.blur();
+        }
+      }}
+      type="number"
+      step={1}
+    />
+  );
+};
diff --git a/desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchTerm.tsx b/desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchTerm.tsx
index 932d5dff3..3f451a2ba 100644
--- a/desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchTerm.tsx
+++ b/desktop/flipper-plugin/src/ui/PowerSearch/PowerSearchTerm.tsx
@@ -11,12 +11,13 @@ import {CloseOutlined} from '@ant-design/icons';
 import {Button, Space} from 'antd';
 import * as React from 'react';
 import {FieldConfig, OperatorConfig} from './PowerSearchConfig';
+import {PowerSearchIntegerTerm} from './PowerSearchIntegerTerm';
 import {PowerSearchStringTerm} from './PowerSearchStringTerm';
 
 export type IncompleteSearchExpressionTerm = {
   field: FieldConfig;
   operator: OperatorConfig;
-  searchValue?: string;
+  searchValue?: any;
 };
 export type SearchExpressionTerm = Required<IncompleteSearchExpressionTerm>;
 
@@ -33,13 +34,10 @@ export const PowerSearchTerm: React.FC<PowerSearchTermProps> = ({
   onCancel,
   onFinalize,
 }) => {
-  return (
-    <Space.Compact block size="small">
-      <Button>{searchTerm.field.label}</Button>
-      <Button>{searchTerm.operator.label}</Button>
-      {searchValueRenderer === 'button' ? (
-        <Button>{searchTerm.searchValue ?? '...'}</Button>
-      ) : (
+  let searchValueInputComponent: React.ReactNode = null;
+  switch (searchTerm.operator.valueType) {
+    case 'STRING': {
+      searchValueInputComponent = (
         <PowerSearchStringTerm
           onCancel={onCancel}
           onChange={(newValue) => {
@@ -49,6 +47,40 @@ export const PowerSearchTerm: React.FC<PowerSearchTermProps> = ({
             });
           }}
         />
+      );
+      break;
+    }
+    case 'INTEGER': {
+      searchValueInputComponent = (
+        <PowerSearchIntegerTerm
+          onCancel={onCancel}
+          onChange={(newValue) => {
+            onFinalize({
+              ...searchTerm,
+              searchValue: newValue,
+            });
+          }}
+        />
+      );
+      break;
+    }
+    default: {
+      console.error(
+        'PowerSearchTerm -> unknownoperator.valueType',
+        searchTerm.operator.valueType,
+        searchTerm,
+      );
+    }
+  }
+
+  return (
+    <Space.Compact block size="small">
+      <Button>{searchTerm.field.label}</Button>
+      <Button>{searchTerm.operator.label}</Button>
+      {searchValueRenderer === 'button' ? (
+        <Button>{searchTerm.searchValue ?? '...'}</Button>
+      ) : (
+        searchValueInputComponent
       )}
       <Button
         icon={<CloseOutlined />}