From 140ff8861ea271dcb66aa697d894e515a53da2aa Mon Sep 17 00:00:00 2001
From: Pritesh Nandgaonkar <prit91@fb.com>
Date: Tue, 19 Jan 2021 14:18:08 -0800
Subject: [PATCH] Add github actions for dependency pod validations (#1834)

Summary:
This PR adds github actions to validate the pods, so that the changes which breaks the validation is not made. This PR also downgrades the version update of OpenSSL, as it doesn't validate the Folly podspec. I have [raised](https://github.com/krzyzanowskim/OpenSSL/issues/113) an issue on the repository which manages the openssl dependency.
## Changelog

- Added githubaction for dependent pod validation
- Downgraded the openssl version, as with upgraded version the folly pod didn't validate.

Pull Request resolved: https://github.com/facebook/flipper/pull/1834

Test Plan: CI

Reviewed By: passy

Differential Revision: D25939525

Pulled By: priteshrnandgaonkar

fbshipit-source-id: f70d043f1f6b2c79028212d8f56c6b8632092e33
---
 .github/workflows/iOS-dependent-pod-lint.yml | 69 ++++++++++++++++++++
 .github/workflows/iOS-pod-lint.yml           | 26 ++++----
 iOS/Podspecs/Flipper-Folly.podspec           |  2 +-
 3 files changed, 82 insertions(+), 15 deletions(-)
 create mode 100644 .github/workflows/iOS-dependent-pod-lint.yml

diff --git a/.github/workflows/iOS-dependent-pod-lint.yml b/.github/workflows/iOS-dependent-pod-lint.yml
new file mode 100644
index 000000000..24cf84742
--- /dev/null
+++ b/.github/workflows/iOS-dependent-pod-lint.yml
@@ -0,0 +1,69 @@
+name: Validate Dependent Podspecs
+on:
+  push:
+    paths:
+      - "iOS/Podspecs/**"
+  pull_request:
+    paths:
+      - "iOS/Podspecs/**"
+
+jobs:
+  lint-flipper_doubleconversion_pod:
+    runs-on: macos-latest
+    defaults:
+      run:
+        working-directory: iOS/Podspecs
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install Dependences
+        run: pod repo update
+      - name: Lint DoubleConversion
+        run: pod spec lint Flipper-DoubleConversion.podspec --use-libraries --allow-warnings --verbose --skip-import-validation
+
+  lint-flipper_folly_pod:
+    runs-on: macos-latest
+    defaults:
+      run:
+        working-directory: iOS/Podspecs
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install Dependences
+        run: pod repo update
+      - name: Lint Folly
+        run: pod spec lint Flipper-Folly.podspec --use-libraries --allow-warnings --verbose --skip-import-validation
+
+  lint-flipper_glog_pod:
+    runs-on: macos-latest
+    defaults:
+      run:
+        working-directory: iOS/Podspecs
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install Dependences
+        run: pod repo update
+      - name: Lint Glog
+        run: pod spec lint Flipper-Glog.podspec --use-libraries --allow-warnings --verbose --skip-import-validation
+
+  lint-flipper_peertalk_pod:
+    runs-on: macos-latest
+    defaults:
+      run:
+        working-directory: iOS/Podspecs
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install Dependences
+        run: pod repo update
+      - name: Lint Peertalk
+        run: pod spec lint Flipper-PeerTalk.podspec --use-libraries --allow-warnings --verbose --skip-import-validation
+
+  lint-flipper_rsocket_pod:
+    runs-on: macos-latest
+    defaults:
+      run:
+        working-directory: iOS/Podspecs
+    steps:
+      - uses: actions/checkout@v2
+      - name: Install Dependences
+        run: pod repo update
+      - name: Lint RSocket
+        run: pod spec lint Flipper-RSocket.podspec --use-libraries --allow-warnings --verbose --skip-import-validation
diff --git a/.github/workflows/iOS-pod-lint.yml b/.github/workflows/iOS-pod-lint.yml
index d78089287..79fd5f2ce 100644
--- a/.github/workflows/iOS-pod-lint.yml
+++ b/.github/workflows/iOS-pod-lint.yml
@@ -6,21 +6,19 @@ jobs:
     runs-on: macos-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Install Dependences
-      run: pod repo update
-      
-    - name: Lint FlipperKit
-      run: pod spec lint FlipperKit.podspec --use-libraries --allow-warnings --verbose --skip-import-validation
-    
+      - uses: actions/checkout@v2
+      - name: Install Dependences
+        run: pod repo update
+
+      - name: Lint FlipperKit
+        run: pod spec lint FlipperKit.podspec --use-libraries --allow-warnings --verbose --skip-import-validation
+
   lint-flipper_pod:
     runs-on: macos-latest
 
     steps:
-    - uses: actions/checkout@v2
-    - name: Install Dependences
-      run: pod repo update
-    - name: Lint Flipper
-      run: pod spec lint Flipper.podspec --use-libraries --allow-warnings --verbose
-      
-      
+      - uses: actions/checkout@v2
+      - name: Install Dependences
+        run: pod repo update
+      - name: Lint Flipper
+        run: pod spec lint Flipper.podspec --use-libraries --allow-warnings --verbose
diff --git a/iOS/Podspecs/Flipper-Folly.podspec b/iOS/Podspecs/Flipper-Folly.podspec
index c67389d3e..8ff3da2d6 100644
--- a/iOS/Podspecs/Flipper-Folly.podspec
+++ b/iOS/Podspecs/Flipper-Folly.podspec
@@ -16,7 +16,7 @@ Pod::Spec.new do |spec|
   spec.dependency 'boost-for-react-native'
   spec.dependency 'Flipper-Glog'
   spec.dependency 'Flipper-DoubleConversion'
-  spec.dependency 'OpenSSL-Universal', '1.1.180'
+  spec.dependency 'OpenSSL-Universal', '1.0.2.20'
   spec.dependency 'CocoaLibEvent', '~> 1.0'
   spec.compiler_flags = '-DFOLLY_HAVE_PTHREAD=1 -DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -DFOLLY_HAVE_LIBGFLAGS=0 -DFOLLY_HAVE_LIBJEMALLOC=0 -DFOLLY_HAVE_PREADV=0 -DFOLLY_HAVE_PWRITEV=0 -DFOLLY_HAVE_TFO=0 -DFOLLY_USE_SYMBOLIZER=0
     -frtti