jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up datainspector test (#1101)

Browse Source 
Summary:
Remove some unnecessary `await`s. Requires https://github.com/facebook/flipper/issues/1100.
Pull Request resolved: https://github.com/facebook/flipper/pull/1101

Test Plan: yarn test

Reviewed By: mweststrate

Differential Revision: D21401237

Pulled By: passy

fbshipit-source-id: 09d68964e8519612d643b83ea61d1cd231b7d169
This commit is contained in:
Pascal Hartig
2020-05-05 06:56:50 -07:00
committed by Facebook GitHub Bot
parent 475a425a20
commit 13a8c4c7e6
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
desktop/app/src/ui/components/data-inspector/__tests__/DataInspector.node.tsx
View File

@@ -62,7 +62,7 @@ const json = {
test('changing collapsed property works', async () => {
const res = render(<ManagedDataInspector data={json} collapsed expandRoot />);
expect(await res.findByText(/is/)).toBeTruthy(); // from expandRoot
expect((await res.queryAllByText(/cool/)).length).toBe(0);
expect(res.queryAllByText(/cool/).length).toBe(0);
res.rerender(
<ManagedDataInspector data={json} collapsed={false} expandRoot />,
@@ -72,23 +72,23 @@ test('changing collapsed property works', async () => {
res.rerender(
<ManagedDataInspector data={json} collapsed={true} expandRoot />,
);
expect((await res.queryAllByText(/cool/)).length).toBe(0);
expect(res.queryAllByText(/cool/).length).toBe(0);
});
test('can manually collapse properties', async () => {
const res = render(<ManagedDataInspector data={json} collapsed expandRoot />);
await res.findByText(/is/); // previewed as key, like: "data: {is, and}"
expect((await res.queryAllByText(/awesomely/)).length).toBe(0);
expect(res.queryAllByText(/awesomely/).length).toBe(0);
// expand twice
fireEvent.click(await res.findByText(/data/));
await res.findByText(/awesomely/);
expect((await res.queryAllByText(/cool/)).length).toBe(0);
expect(res.queryAllByText(/cool/).length).toBe(0);
fireEvent.click(await res.findByText(/is/));
await res.findByText(/cool/);
expect((await res.queryAllByText(/json/)).length).toBe(0); // this node is not shown
expect(res.queryAllByText(/json/).length).toBe(0); // this node is not shown
// collapsing everything again
fireEvent.click(await res.findByText(/data/));