From 1351496c2ce238318d820a7647c1241b8a6e705d Mon Sep 17 00:00:00 2001 From: Pascal Hartig Date: Wed, 4 Mar 2020 11:00:19 -0800 Subject: [PATCH] Re-enable release editing on windows Summary: There's a lot going on here: - I'm moving over to android build hosts. They're are faster and more plentiful. They seem to work just fine for what we do. We already have a tenant capacity for them. *Edit:* Even more importantly, we need `adb` for certain tasks. The Android SDK isn't installed on Lego. - I'm splitting our `sandcastle_setup` up into a pure yarn setup and an electron setup. The latter downloads from LFS and installs Wine (on Linux) which takes some time. This isn't needed unless we actually run Electron. That's for builds and Electron tests only. - There were so, so many weird little edge cases. One of them is that `electron-builder`'s `app-builder` (a go app) switches between an x86 and an x86_64 version of wine to use for signing Windows apps, but only on Mac. On Linux it's hard-coded to 32bits. So we need to manually override the binary in the cache. I do this in the script rather in the cache because this is impossible to remember when upgrading. - Wine is only bundled for Mac. On Linux you have to get it somewhere else. Luckily, we run as root, so we can do that. - `$HOME` is set to `/var/twscsvc` which isn't owned by `root` but by `twscsvc`. Wine no happy. So we have to manually set this to a path that `root` owns. Hence the `export HOME`. Reviewed By: nikoant Differential Revision: D20223753 fbshipit-source-id: 0b2b09d19409ce172f395a7d1f85ec601654c6f6 --- scripts/build-release.ts | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/scripts/build-release.ts b/scripts/build-release.ts index e0a71e78f..238568e95 100755 --- a/scripts/build-release.ts +++ b/scripts/build-release.ts @@ -111,10 +111,7 @@ async function buildDist(buildFolder: string) { output: path.join(__dirname, '..', 'dist'), }, electronDownload: electronDownloadOptions, - npmRebuild: false, - win: { - signAndEditExecutable: false - } + npmRebuild: false }, projectDir: buildFolder, targets,