jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Show PluginInfo for unavailable and not installed plugins

Browse Source 
Summary: Updated PluginInfo component to show info about uninstalled and unavailable plugins in addition to enabled/disabled. Now any selected plugin will be shown there. For uninstalled plugins we will show "Install" action button. For unavailable plugins we wiil show an alert describing why plugin is unavailable.

Reviewed By: mweststrate

Differential Revision: D29254970

fbshipit-source-id: 0de32da5b5550ff6b7d452abf6ff7259677aebc5
This commit is contained in:
Anton Nikolaev
2021-06-29 13:00:18 -07:00
committed by Facebook GitHub Bot
parent e36eec82b2
commit 116f6eb5ba
3 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/app/src/PluginContainer.tsx
View File

@@ -54,7 +54,7 @@ import semver from 'semver';
import {loadPlugin} from './reducers/pluginManager'; import {loadPlugin} from './reducers/pluginManager';
import {produce} from 'immer'; import {produce} from 'immer';
import {reportUsage} from './utils/metrics'; import {reportUsage} from './utils/metrics';
import PluginInfo from './chrome/fb-stubs/PluginInfo'; import {PluginInfo} from './chrome/fb-stubs/PluginInfo';
import {getActiveClient, getActivePlugin} from './selectors/connections'; import {getActiveClient, getActivePlugin} from './selectors/connections';
const {Text, Link} = Typography; const {Text, Link} = Typography;

2
desktop/app/src/chrome/fb-stubs/PluginInfo.tsx
View File

@@ -26,7 +26,7 @@ const Waiting = styled(Layout.Container)({
textAlign: 'center', textAlign: 'center',
}); });
export default function PluginInfo() { export function PluginInfo() {
const pluginId = useStore((state) => state.connections.selectedPlugin); const pluginId = useStore((state) => state.connections.selectedPlugin);
const enabledPlugins = useStore((state) => state.connections.enabledPlugins); const enabledPlugins = useStore((state) => state.connections.enabledPlugins);
const enabledDevicePlugins = useStore( const enabledDevicePlugins = useStore(

11
desktop/app/src/selectors/connections.tsx
View File

@@ -24,6 +24,7 @@ const getUserPreferredDevice = (state: State) =>
state.connections.userPreferredDevice; state.connections.userPreferredDevice;
const getClients = (state: State) => state.connections.clients; const getClients = (state: State) => state.connections.clients;
const getDevices = (state: State) => state.connections.devices; const getDevices = (state: State) => state.connections.devices;
const getPluginDownloads = (state: State) => state.pluginDownloads;
export const getActiveClient = createSelector( export const getActiveClient = createSelector(
getSelectedApp, getSelectedApp,
@@ -133,3 +134,13 @@ export const getActivePlugin = createSelector(
return pluginList[pluginId] ?? null; return pluginList[pluginId] ?? null;
}, },
); );
export const getPluginDownloadStatusMap = createSelector(
getPluginDownloads,
(downloads) => {
const downloadMap = new Map(
Object.values(downloads).map((x) => [x.plugin.id, x]),
);
return downloadMap;
},
);