From 10e90f3f57840c66b75824dbd8eaec09ffd4bb5e Mon Sep 17 00:00:00 2001 From: Benjamin Elo Date: Mon, 2 Sep 2019 03:54:48 -0700 Subject: [PATCH] Migrated Timeline to TypeScript Summary: Migrated Timeline.js to Timeline.tsx Reviewed By: danielbuechele Differential Revision: D17132222 fbshipit-source-id: ffe5b74459d1f3ec48873a94a95c40e855aa45da --- .../components/{Timeline.js => Timeline.tsx} | 23 +++++++++---------- src/plugins/navigation/components/index.js | 2 +- 2 files changed, 12 insertions(+), 13 deletions(-) rename src/plugins/navigation/components/{Timeline.js => Timeline.tsx} (82%) diff --git a/src/plugins/navigation/components/Timeline.js b/src/plugins/navigation/components/Timeline.tsx similarity index 82% rename from src/plugins/navigation/components/Timeline.js rename to src/plugins/navigation/components/Timeline.tsx index 3191f6bd8..e36833c26 100644 --- a/src/plugins/navigation/components/Timeline.js +++ b/src/plugins/navigation/components/Timeline.tsx @@ -3,20 +3,19 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * @format - * @flow strict-local */ import {colors, FlexCenter, styled, LoadingIndicator} from 'flipper'; -import {NavigationInfoBox} from './'; +import NavigationInfoBox from './NavigationInfoBox'; +import {Bookmark, NavigationEvent, URI} from '../types'; +import React from 'react'; -import type {Bookmark, NavigationEvent} from '../flow-types'; - -type Props = {| - bookmarks: Map, - events: Array, - onNavigate: string => void, - onFavorite: string => void, -|}; +type Props = { + bookmarks: Map; + events: Array; + onNavigate: (uri: URI) => void; + onFavorite: (uri: URI) => void; +}; const TimelineContainer = styled('div')({ overflowY: 'scroll', @@ -53,7 +52,7 @@ export default (props: Props) => { No Navigation Events to Show ) : ( - {events.map((event: NavigationEvent, idx) => { + {events.map((event: NavigationEvent, idx: number) => { return ( {event.uri != null || event.className != null ? ( @@ -62,7 +61,7 @@ export default (props: Props) => { ) : ( - + )} diff --git a/src/plugins/navigation/components/index.js b/src/plugins/navigation/components/index.js index b7074efc0..34afe8d8e 100644 --- a/src/plugins/navigation/components/index.js +++ b/src/plugins/navigation/components/index.js @@ -16,4 +16,4 @@ export { } from './RequiredParametersDialog.tsx'; export {default as SaveBookmarkDialog} from './SaveBookmarkDialog.tsx'; export {default as SearchBar} from './SearchBar'; -export {default as Timeline} from './Timeline'; +export {default as Timeline} from './Timeline.tsx';