Move plugins to "sonar/desktop/plugins"

Summary:
Plugins moved from "sonar/desktop/src/plugins" to "sonar/desktop/plugins".

Fixed all the paths after moving.

New "desktop" folder structure:
- `src` - Flipper desktop app JS code executing in Electron Renderer (Chrome) process.
- `static` - Flipper desktop app JS code executing in Electron Main (Node.js) process.
- `plugins` - Flipper desktop JS plugins.
- `pkg` - Flipper packaging lib and CLI tool.
- `doctor` - Flipper diagnostics lib and CLI tool.
- `scripts` - Build scripts for Flipper desktop app.
- `headless` - Headless version of Flipper desktop app.
- `headless-tests` - Integration tests running agains Flipper headless version.

Reviewed By: mweststrate

Differential Revision: D20344186

fbshipit-source-id: d020da970b2ea1e001f9061a8782bfeb54e31ba0

desktop/static/main.ts

@@ -92,8 +92,8 @@ const pluginPaths = (config.pluginPaths ?? [])
     ...(skipLoadingEmbeddedPlugins
       ? []
       : [
-          path.join(__dirname, '..', 'src', 'plugins'),
-          path.join(__dirname, '..', 'src', 'fb', 'plugins'),
+          path.join(__dirname, '..', 'plugins'),
+          path.join(__dirname, '..', 'plugins', 'fb'),
         ]),
   ])
   .map(expandTilde)

desktop/static/package.json

@@ -33,6 +33,7 @@
     "ws": "7.2.0"
   },
   "devDependencies": {
-    "@babel/preset-env": "^7.8.3"
+    "@babel/preset-env": "^7.8.3",
+    "@types/electron-devtools-installer": "^2.2.0"
   }
 }

desktop/static/transforms/fb-stubs.js

@@ -12,6 +12,7 @@ const path = require('path');
 const replaceFBStubs = fs.existsSync(
   path.join(__dirname, '..', '..', 'src', 'fb'),
 );
+const isFBFile = filePath => filePath.includes(`${path.sep}fb${path.sep}`);
 
 const requireFromFolder = (folder, path) =>
   new RegExp(folder + '/[A-Za-z0-9.-_]+(.js)?$', 'g').test(path);
@@ -20,7 +21,7 @@ module.exports = function(babel) {
   return {
     name: 'replace-dynamic-requires',
     visitor: {
-      CallExpression(path) {
+      CallExpression(path, state) {
         if (
           replaceFBStubs &&
           path.node.type === 'CallExpression' &&
@@ -28,9 +29,12 @@ module.exports = function(babel) {
           path.node.callee.name === 'require' &&
           path.node.arguments.length > 0
         ) {
-          if (requireFromFolder('fb', path.node.arguments[0].value)) {
+          if (
+            requireFromFolder('fb', path.node.arguments[0].value) &&
+            !isFBFile(state.file.opts.filename)
+          ) {
             throw new Error(
-              'Do not require directly from fb/, but rather from fb-stubs/ to not break flow-typing and make sure stubs are up-to-date.',
+              'For files which are not under fb/ do not require directly from fb/, but rather from fb-stubs/ to not break flow-typing and make sure stubs are up-to-date.',
             );
           } else if (
             requireFromFolder('fb-stubs', path.node.arguments[0].value)

desktop/static/yarn.lock

@@ -953,6 +953,11 @@
   resolved "https://registry.yarnpkg.com/@types/color-name/-/color-name-1.1.1.tgz#1c1261bbeaa10a8055bbc5d8ab84b7b2afc846a0"
   integrity sha512-rr+OQyAjxze7GgWrSaJwydHStIhHq2lvY3BOC2Mj7KnzI7XK0Uw1TOOdI9lDoajEbSWLiYgoo4f1R51erQfhPQ==
 
+"@types/electron-devtools-installer@^2.2.0":
+  version "2.2.0"
+  resolved "https://registry.yarnpkg.com/@types/electron-devtools-installer/-/electron-devtools-installer-2.2.0.tgz#32ee4ebbe99b3daf9847a6d2097dc00b5de94f10"
+  integrity sha512-HJNxpaOXuykCK4rQ6FOMxAA0NLFYsf7FiPFGmab0iQmtVBHSAfxzy3MRFpLTTDDWbV0yD2YsHOQvdu8yCqtCfw==
+
 "@types/istanbul-lib-coverage@*", "@types/istanbul-lib-coverage@^2.0.0":
   version "2.0.1"
   resolved "https://registry.yarnpkg.com/@types/istanbul-lib-coverage/-/istanbul-lib-coverage-2.0.1.tgz#42995b446db9a48a11a07ec083499a860e9138ff"