jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

handle error when device disconected

Browse Source 
Summary: Log views were being generated, this seems like a reasonable solution.

Reviewed By: zats

Differential Revision: D49547368

fbshipit-source-id: 575dd81a7c9b9a831d1dfb46088c2f5e1d731f22
This commit is contained in:
Luke De Feo
2023-09-25 02:02:26 -07:00
committed by Facebook GitHub Bot
parent f2e402e6e9
commit 10d5a2933a
6 changed files with 40 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
desktop/plugins/public/ui-debugger/components/tree/TreeControls.tsx
View File

@@ -52,7 +52,7 @@ export const TreeControls: React.FC = () => {
const frameworkEventMetadata = useValue(instance.frameworkEventMetadata);
const currentTraversalMode = useValue(instance.uiState.currentTraversalMode);
const currentTraversalMode = useValue(instance.uiState.traversalMode);
const supportedTraversalModes = useValue(
instance.uiState.supportedTraversalModes,
);
@@ -65,6 +65,8 @@ export const TreeControls: React.FC = () => {
}
};
const isConnected = useValue(instance.uiState.isConnected);
const menus = supportedTraversalModes.map((mode) => ({
key: mode,
label: labelForMode(mode),
@@ -74,18 +76,18 @@ export const TreeControls: React.FC = () => {
<Layout.Horizontal gap="medium" pad="medium">
{supportedTraversalModes.length > 1 ? (
<Dropdown
disabled={!isConnected}
menu={{
selectable: true,
selectedKeys: [currentTraversalMode],
items: menus,
onSelect: async (event) => {
const mode = event.selectedKeys[0] as TraversalMode;
instance.uiActions.setCurrentTraversalMode(mode); // update UI
await instance.onTraversalModeChange(mode); // update mobile client
instance.uiActions.onSetTraversalMode(mode); // update UI
},
}}>
<Tooltip title="Debugger Mode">
<Button shape="circle">
<Tooltip title={isConnected ? 'Debugger Mode' : 'App disconnected'}>
<Button disabled={!isConnected} shape="circle">
<AppstoreOutlined />
</Button>
</Tooltip>

2
desktop/plugins/public/ui-debugger/components/visualizer/Visualization2D.tsx
View File

@@ -51,7 +51,7 @@ export const Visualization2D: React.FC<
const hoveredNodes = useValue(instance.uiState.hoveredNodes);
const hoveredNodeId = head(hoveredNodes);
const wireFrameMode = useValue(instance.uiState.wireFrameMode);
const traversalMode = useValue(instance.uiState.currentTraversalMode);
const traversalMode = useValue(instance.uiState.traversalMode);
const [targetMode, setTargetMode] = useState<TargetModeState>({
state: 'disabled',