jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Back out "Automatically set Android devices into the permissive mode"

Browse Source 
Summary:
Original commit changeset: 471470c5ca91

Original Phabricator Diff: D35356211 (501abc6b55)

Recently, bloks users reported that android emulators lost connection upon launching Flipper. (S270689)

Manual bisecting indicates that remote emulators won't crash on v0.142.362128844 (4/6) but crash on 0.143.365099607 (4/21).

Looking at https://www.internalfb.com/code/fbsource/[history]/xplat/scripts/.flipperversion.v2, and backing out D35356211 (501abc6b55) fixes the issue.

It's still unclear why setting `setIntoPermissiveMode` would crash/disconnect the android emulators, I'd defer Flipper team to investigate this further but this diff should unblock all the android bloks emulator + Flipper use case.

Reviewed By: lblasa

Differential Revision: D36263724

fbshipit-source-id: e8674730c0185457f6eda347ce7d9a41f9e1a2a4
This commit is contained in:
Mengke Ding
2022-05-09 16:04:14 -07:00
committed by Facebook GitHub Bot
parent 57e3253bb0
commit 0ee8f09fe5
3 changed files with 0 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
desktop/flipper-server-core/src/devices/android/androidDeviceManager.tsx
View File

@@ -90,8 +90,6 @@ export class AndroidDeviceManager {
// The default way of capturing screenshots through adb does not seem to work
// There is a way of getting a screenshot through KaiOS dev tools though
if (androidLikeDevice instanceof AndroidDevice) {
await androidLikeDevice.setIntoPermissiveMode();
const screenRecordAvailable =
await androidLikeDevice.screenRecordAvailable();
androidLikeDevice.info.features.screenCaptureAvailable =