From 0e90873096f8e00ca2997b732da142b8e596e346 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Thu, 5 Oct 2023 04:37:16 -0700 Subject: [PATCH] Do not block for device manager to become ready Summary: ^ Also, if an error happens, do not swallow it, rethrow. Reviewed By: passy Differential Revision: D49912780 fbshipit-source-id: 30451110d8c5776e2b0826d6e924ab5fe98cd7e2 --- desktop/flipper-server-core/src/FlipperServerImpl.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/desktop/flipper-server-core/src/FlipperServerImpl.tsx b/desktop/flipper-server-core/src/FlipperServerImpl.tsx index c3f7615c6..5f0e55f2a 100644 --- a/desktop/flipper-server-core/src/FlipperServerImpl.tsx +++ b/desktop/flipper-server-core/src/FlipperServerImpl.tsx @@ -199,13 +199,17 @@ export class FlipperServerImpl implements FlipperServer { await this.createFolders(); await this.server.init(); await this.pluginManager.start(); - await this.startDeviceListeners(); + + this.startDeviceListeners(); + this.setServerState('started'); } catch (e) { if (!isHandledStartupError(e)) { console.error('Failed to start FlipperServer', e); } this.setServerState('error', e); + + throw e; } }