Run CLANGFORMAT on sample

Summary: This diff runs CLANGFORMAT lint on sample. I have added CLANGFORMAT as the lint engined for objc files in xplat/sonar. Right now the iOS folder is not formatted according to CLANGFORMAT.

Reviewed By: passy

Differential Revision: D19942174

fbshipit-source-id: bef3e67bf31f13bb52417c81c4c330d6c258872d

iOS/Sample/AppDelegate.h

@@ -7,5 +7,5 @@
 
 #import <UIKit/UIKit.h>
 
-@interface AppDelegate : UIResponder <UIApplicationDelegate>
+@interface AppDelegate : UIResponder<UIApplicationDelegate>
 @end

iOS/Sample/AppDelegate.m

@@ -7,51 +7,61 @@
 
 #import "AppDelegate.h"
 #import <FlipperKit/FlipperClient.h>
+#import <FlipperKitExamplePlugin/FlipperKitExamplePlugin.h>
+#import <FlipperKitLayoutComponentKitSupport/FlipperKitLayoutComponentKitSupport.h>
 #import <FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.h>
 #import <FlipperKitNetworkPlugin/FlipperKitNetworkPlugin.h>
-#import <FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.h>
-#import <FlipperKitLayoutComponentKitSupport/FlipperKitLayoutComponentKitSupport.h>
-#import <FlipperKitExamplePlugin/FlipperKitExamplePlugin.h>
-#import <SKIOSNetworkPlugin/SKIOSNetworkAdapter.h>
 #import <FlipperKitReactPlugin/FlipperKitReactPlugin.h>
 #import <FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.h>
+#import <SKIOSNetworkPlugin/SKIOSNetworkAdapter.h>
 
 #import "MainViewController.h"
 #import "RootViewController.h"
 
 #if !FB_SONARKIT_ENABLED
-#error "Sample need to be run with SonarKit enabled in order to properly interact with Sonar. SonarKit is enabled by default if its a debug build."
+#error \
+    "Sample need to be run with SonarKit enabled in order to properly interact with Sonar. SonarKit is enabled by default if its a debug build."
 #endif
 
 @implementation AppDelegate {
-  UIWindow *_window;
+  UIWindow* _window;
 }
 
-- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
+- (BOOL)application:(UIApplication*)application
-{
+    didFinishLaunchingWithOptions:(NSDictionary*)launchOptions {
   _window = [[UIWindow alloc] initWithFrame:[[UIScreen mainScreen] bounds]];
-  FlipperClient *client = [FlipperClient sharedClient];
+  FlipperClient* client = [FlipperClient sharedClient];
 
-  SKDescriptorMapper *layoutDescriptorMapper = [[SKDescriptorMapper alloc] initWithDefaults];
+  SKDescriptorMapper* layoutDescriptorMapper =
-  [FlipperKitLayoutComponentKitSupport setUpWithDescriptorMapper: layoutDescriptorMapper];
+      [[SKDescriptorMapper alloc] initWithDefaults];
-  [client addPlugin: [[FlipperKitLayoutPlugin alloc] initWithRootNode: application
+  [FlipperKitLayoutComponentKitSupport
-                                               withDescriptorMapper: layoutDescriptorMapper]];
+      setUpWithDescriptorMapper:layoutDescriptorMapper];
+  [client addPlugin:[[FlipperKitLayoutPlugin alloc]
+                            initWithRootNode:application
+                        withDescriptorMapper:layoutDescriptorMapper]];
 
   [client addPlugin:[[FKUserDefaultsPlugin alloc] initWithSuiteName:nil]];
 
-  [[FlipperClient sharedClient] addPlugin: [[FlipperKitNetworkPlugin alloc] initWithNetworkAdapter:[SKIOSNetworkAdapter new]]];
+  [[FlipperClient sharedClient]
+      addPlugin:[[FlipperKitNetworkPlugin alloc]
+                    initWithNetworkAdapter:[SKIOSNetworkAdapter new]]];
   [client addPlugin:[FlipperKitExamplePlugin sharedInstance]];
   [client addPlugin:[FlipperKitReactPlugin new]];
   [client start];
 
-  UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard" bundle:nil];
+  UIStoryboard* storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard"
-  MainViewController *mainViewController = [storyboard instantiateViewControllerWithIdentifier:@"MainViewController"];
+                                                       bundle:nil];
+  MainViewController* mainViewController = [storyboard
+      instantiateViewControllerWithIdentifier:@"MainViewController"];
 
-  UINavigationController *navigationController = [[UINavigationController alloc] initWithRootViewController: mainViewController];
+  UINavigationController* navigationController = [[UINavigationController alloc]
+      initWithRootViewController:mainViewController];
   navigationController.navigationBar.topItem.title = @"Sample";
   navigationController.navigationBar.translucent = NO;
 
-  [_window setRootViewController: [[UINavigationController alloc] initWithRootViewController: mainViewController]];
+  [_window
+      setRootViewController:[[UINavigationController alloc]
+                                initWithRootViewController:mainViewController]];
   [_window makeKeyAndVisible];
 
   NSLog(@"Hello from Flipper in an Objc app!");

iOS/Sample/CommunicationDemoViewController.h

@@ -7,6 +7,7 @@
 
 #import <UIKit/UIKit.h>
 
-@interface CommunicationDemoViewController : UIViewController<UITableViewDataSource>
+@interface CommunicationDemoViewController
+    : UIViewController<UITableViewDataSource>
 
 @end

iOS/Sample/CommunicationDemoViewController.mm

@@ -8,10 +8,11 @@
 #import "CommunicationDemoViewController.h"
 #import <FlipperKitExamplePlugin/FlipperKitExamplePlugin.h>
 
-@interface CommunicationDemoViewController()<FlipperKitExampleCommunicationResponderDelegate>
+@interface CommunicationDemoViewController ()<
-@property (strong, nonatomic) NSMutableArray<NSString *> *messagesToDisplay;
+    FlipperKitExampleCommunicationResponderDelegate>
-@property (weak, nonatomic) IBOutlet UITextField *messageTextField;
+@property(strong, nonatomic) NSMutableArray<NSString*>* messagesToDisplay;
-@property (weak, nonatomic) IBOutlet UITableView *tableView;
+@property(weak, nonatomic) IBOutlet UITextField* messageTextField;
+@property(weak, nonatomic) IBOutlet UITableView* tableView;
 @end
 
 @implementation CommunicationDemoViewController
@@ -21,27 +22,31 @@
   [FlipperKitExamplePlugin sharedInstance].delegate = self;
 }
 
-- (IBAction)tappedTriggerNotification:(UIButton *)sender {
+- (IBAction)tappedTriggerNotification:(UIButton*)sender {
   [[FlipperKitExamplePlugin sharedInstance] triggerNotification];
 }
 
-- (IBAction)tappedSendMessage:(UIButton *)sender {
+- (IBAction)tappedSendMessage:(UIButton*)sender {
   if (self.messageTextField.text.length > 0) {
-        [[FlipperKitExamplePlugin sharedInstance] sendMessage:self.messageTextField.text];
+    [[FlipperKitExamplePlugin sharedInstance]
+        sendMessage:self.messageTextField.text];
   }
 }
 
-- (nonnull UITableViewCell *)tableView:(nonnull UITableView *)tableView cellForRowAtIndexPath:(nonnull NSIndexPath *)indexPath {
+- (nonnull UITableViewCell*)tableView:(nonnull UITableView*)tableView
-    UITableViewCell *cell = [tableView dequeueReusableCellWithIdentifier:@"reusableCell"];
+                cellForRowAtIndexPath:(nonnull NSIndexPath*)indexPath {
+  UITableViewCell* cell =
+      [tableView dequeueReusableCellWithIdentifier:@"reusableCell"];
   cell.textLabel.text = self.messagesToDisplay[indexPath.row];
   return cell;
 }
 
-- (NSInteger)tableView:(nonnull UITableView *)tableView numberOfRowsInSection:(NSInteger)section {
+- (NSInteger)tableView:(nonnull UITableView*)tableView
+    numberOfRowsInSection:(NSInteger)section {
   return self.messagesToDisplay.count;
 }
 
-- (void)messageReceived:(NSString *)msg {
+- (void)messageReceived:(NSString*)msg {
   if (msg) {
     if (!self.messagesToDisplay) {
       self.messagesToDisplay = @[].mutableCopy;

iOS/Sample/MainViewController.mm

@@ -7,11 +7,11 @@
 
 #import "MainViewController.h"
 
+#import <FlipperKit/FlipperDiagnosticsViewController.h>
+#import "CommunicationDemoViewController.h"
 #import "NetworkViewController.h"
 #import "RootViewController.h"
 #import "UserDefaultsViewController.h"
-#import "CommunicationDemoViewController.h"
-#import <FlipperKit/FlipperDiagnosticsViewController.h>
 
 @interface MainViewController ()
 
@@ -23,39 +23,51 @@
   [super viewDidLoad];
   // Do any additional setup after loading the view.
 }
-- (IBAction)tappedDiagnosticScreen:(UIButton *)sender {
+- (IBAction)tappedDiagnosticScreen:(UIButton*)sender {
-    FlipperDiagnosticsViewController *controller = [[FlipperDiagnosticsViewController alloc] init];
+  FlipperDiagnosticsViewController* controller =
+      [[FlipperDiagnosticsViewController alloc] init];
   [self.navigationController pushViewController:controller animated:true];
 }
 
-- (IBAction)tappedComponentKitLayout:(UIButton *)sender {
+- (IBAction)tappedComponentKitLayout:(UIButton*)sender {
-  RootViewController *rootViewController = [RootViewController new];
+  RootViewController* rootViewController = [RootViewController new];
 
-  [self.navigationController pushViewController:rootViewController animated:true];
+  [self.navigationController pushViewController:rootViewController
+                                       animated:true];
 }
 
-- (IBAction)tappedNetworkInspector:(UIButton *)sender {
+- (IBAction)tappedNetworkInspector:(UIButton*)sender {
-  UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard" bundle:nil];
+  UIStoryboard* storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard"
-  NetworkViewController *networkViewController = [storyboard instantiateViewControllerWithIdentifier:@"NetworkViewController"];
+                                                       bundle:nil];
+  NetworkViewController* networkViewController = [storyboard
+      instantiateViewControllerWithIdentifier:@"NetworkViewController"];
 
-  [self.navigationController pushViewController:networkViewController animated:true];
+  [self.navigationController pushViewController:networkViewController
+                                       animated:true];
 }
 
 - (IBAction)tappedUserDefaults:(id)sender {
-    UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard" bundle:nil];
+  UIStoryboard* storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard"
-    UserDefaultsViewController *userDefaultsViewController = [storyboard instantiateViewControllerWithIdentifier:@"UserDefaultsViewController"];
+                                                       bundle:nil];
+  UserDefaultsViewController* userDefaultsViewController = [storyboard
+      instantiateViewControllerWithIdentifier:@"UserDefaultsViewController"];
 
-    [self.navigationController pushViewController:userDefaultsViewController animated:true];
+  [self.navigationController pushViewController:userDefaultsViewController
+                                       animated:true];
 }
 
-- (IBAction)tappedCommunicationDemo:(UIButton *)sender {
+- (IBAction)tappedCommunicationDemo:(UIButton*)sender {
-    UIStoryboard *storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard" bundle:nil];
+  UIStoryboard* storyboard = [UIStoryboard storyboardWithName:@"MainStoryBoard"
-    CommunicationDemoViewController *communicationDemoViewController = [storyboard instantiateViewControllerWithIdentifier:@"CommunicationDemoViewController"];
+                                                       bundle:nil];
-    [self.navigationController pushViewController:communicationDemoViewController animated:true];
+  CommunicationDemoViewController* communicationDemoViewController =
+      [storyboard instantiateViewControllerWithIdentifier:
+                      @"CommunicationDemoViewController"];
+  [self.navigationController pushViewController:communicationDemoViewController
+                                       animated:true];
 }
 
-- (IBAction)tappedCauseCrash:(UIButton *)sender {
+- (IBAction)tappedCauseCrash:(UIButton*)sender {
-  NSArray *arr = @[];
+  NSArray* arr = @[];
   [arr objectAtIndex:10];
 }
 

iOS/Sample/NetworkViewController.m

@@ -18,8 +18,16 @@
   self.navigationItem.title = @"Network";
 }
 
-- (IBAction)tappedGithubLitho:(UIButton *)sender {
+- (IBAction)tappedGithubLitho:(UIButton*)sender {
-  [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:@"https://raw.githubusercontent.com/facebook/litho/master/docs/static/logo.png"] completionHandler:^(NSData *_Nullable data, NSURLResponse *_Nullable response, NSError *_Nullable error) {
+  [[[NSURLSession sharedSession]
+        dataTaskWithURL:
+            [NSURL
+                URLWithString:
+                    @"https://raw.githubusercontent.com/facebook/litho/master/docs/static/logo.png"]
+      completionHandler:^(
+          NSData* _Nullable data,
+          NSURLResponse* _Nullable response,
+          NSError* _Nullable error) {
         if (error && !data) {
           return;
         }
@@ -27,57 +35,83 @@
       }] resume];
 }
 
-- (IBAction)tappedPOSTAPI:(UIButton *)sender {
+- (IBAction)tappedPOSTAPI:(UIButton*)sender {
-  NSString *post = @"https://demo9512366.mockable.io/FlipperPost";
+  NSString* post = @"https://demo9512366.mockable.io/FlipperPost";
-  NSURL *url = [NSURL URLWithString:post];
+  NSURL* url = [NSURL URLWithString:post];
-  NSMutableURLRequest *urlRequest = [NSMutableURLRequest requestWithURL: url];
+  NSMutableURLRequest* urlRequest = [NSMutableURLRequest requestWithURL:url];
   [urlRequest addValue:@"application/json" forHTTPHeaderField:@"Content-Type"];
   [urlRequest addValue:@"application/json" forHTTPHeaderField:@"Accept"];
-  NSDictionary *mapData = [[NSDictionary alloc] initWithObjectsAndKeys: @"Flipper", @"app",
+  NSDictionary* mapData =
-                           @"Its awesome", @"remarks",
+      [[NSDictionary alloc] initWithObjectsAndKeys:@"Flipper",
+                                                   @"app",
+                                                   @"Its awesome",
+                                                   @"remarks",
                                                    nil];
-  NSError *error = nil;
+  NSError* error = nil;
-  NSData *postData = [NSJSONSerialization dataWithJSONObject:mapData options:0 error:&error];
+  NSData* postData = [NSJSONSerialization dataWithJSONObject:mapData
+                                                     options:0
+                                                       error:&error];
   [urlRequest setHTTPBody:postData];
   [urlRequest setHTTPMethod:@"POST"];
-  __weak NetworkViewController *weakSelf = self;
+  __weak NetworkViewController* weakSelf = self;
-  [[[NSURLSession sharedSession] dataTaskWithRequest:urlRequest completionHandler:^(NSData *_Nullable data, NSURLResponse *_Nullable response, NSError *_Nullable dataTaskError) {
+  [[[NSURLSession sharedSession]
-
+      dataTaskWithRequest:urlRequest
+        completionHandler:^(
+            NSData* _Nullable data,
+            NSURLResponse* _Nullable response,
+            NSError* _Nullable dataTaskError) {
           if (dataTaskError || !data) {
-      [weakSelf showAlertWithMessage:@"Received error in POST API response"];
+            [weakSelf
+                showAlertWithMessage:@"Received error in POST API response"];
             return;
           }
-    NSDictionary *dict = [NSJSONSerialization JSONObjectWithData:data options:0 error:&dataTaskError];
+          NSDictionary* dict =
+              [NSJSONSerialization JSONObjectWithData:data
+                                              options:0
+                                                error:&dataTaskError];
           NSLog(@"MSG-POST: %@", dict[@"msg"]);
 
           [weakSelf showAlertWithMessage:@"Received response from POST API"];
-
         }] resume];
 }
 
-- (IBAction)tappedGetAPI:(UIButton *)sender {
+- (IBAction)tappedGetAPI:(UIButton*)sender {
-  __weak NetworkViewController *weakSelf = self;
+  __weak NetworkViewController* weakSelf = self;
-  [[[NSURLSession sharedSession] dataTaskWithURL:[NSURL URLWithString:@"https://demo9512366.mockable.io/FlipperGet"] completionHandler:^(NSData *_Nullable data, NSURLResponse *_Nullable response, NSError *_Nullable error) {
+  [[[NSURLSession sharedSession]
+        dataTaskWithURL:
+            [NSURL URLWithString:@"https://demo9512366.mockable.io/FlipperGet"]
+      completionHandler:^(
+          NSData* _Nullable data,
+          NSURLResponse* _Nullable response,
+          NSError* _Nullable error) {
         if (error || !data) {
           [weakSelf showAlertWithMessage:@"Received error in GET API response"];
           return;
         }
-    NSDictionary *dict = [NSJSONSerialization JSONObjectWithData:data options:0 error:&error];
+        NSDictionary* dict = [NSJSONSerialization JSONObjectWithData:data
+                                                             options:0
+                                                               error:&error];
         NSLog(@"MSG-GET: %@", dict[@"msg"]);
         [weakSelf showAlertWithMessage:@"Received response from GET API"];
       }] resume];
 }
 
-- (void)showAlertWithMessage:(nonnull NSString *)msg {
+- (void)showAlertWithMessage:(nonnull NSString*)msg {
   dispatch_async(dispatch_get_main_queue(), ^{
-    UIAlertController *alertController = [self alertControllerForMessage:msg];
+    UIAlertController* alertController = [self alertControllerForMessage:msg];
     [self presentViewController:alertController animated:true completion:nil];
   });
 }
 
-- (UIAlertController *)alertControllerForMessage:(nonnull NSString *)msg {
+- (UIAlertController*)alertControllerForMessage:(nonnull NSString*)msg {
-  UIAlertController *controller = [UIAlertController alertControllerWithTitle:@"Flipper" message:msg preferredStyle:UIAlertControllerStyleAlert];
+  UIAlertController* controller =
-  UIAlertAction *action = [UIAlertAction actionWithTitle:@"Ok" style:UIAlertActionStyleDefault handler:nil];
+      [UIAlertController alertControllerWithTitle:@"Flipper"
+                                          message:msg
+                                   preferredStyle:UIAlertControllerStyleAlert];
+  UIAlertAction* action =
+      [UIAlertAction actionWithTitle:@"Ok"
+                               style:UIAlertActionStyleDefault
+                             handler:nil];
   [controller addAction:action];
   return controller;
 }

iOS/Sample/RootViewController.mm

@@ -20,19 +20,19 @@
 
 @interface RootViewController ()
 
-@property (strong, nonatomic) CKComponentHostingView *rootCKHostingView;
+@property(strong, nonatomic) CKComponentHostingView* rootCKHostingView;
 
 @end
 
 @implementation RootViewController
 
-- (instancetype)init
+- (instancetype)init {
-{
   if (self = [super init]) {
     _rootCKHostingView = [[CKComponentHostingView alloc]
         initWithComponentProvider:[self class]
-                          sizeRangeProvider:
+                sizeRangeProvider:[CKComponentFlexibleSizeRangeProvider
-                          [CKComponentFlexibleSizeRangeProvider providerWithFlexibility:CKComponentSizeRangeFlexibleHeight]];
+                                      providerWithFlexibility:
+                                          CKComponentSizeRangeFlexibleHeight]];
 
     [self.view addSubview:_rootCKHostingView];
     [self loadViewIfNeeded];
@@ -46,51 +46,42 @@
   self.edgesForExtendedLayout = UIRectEdgeNone;
 }
 
-- (void)viewDidLayoutSubviews
+- (void)viewDidLayoutSubviews {
-{
   [super viewDidLayoutSubviews];
   _rootCKHostingView.frame = self.view.bounds;
 }
 
-+ (CKComponent *)componentForModel:(id<NSObject>)model context:(id<NSObject>)context {
++ (CKComponent*)componentForModel:(id<NSObject>)model
+                          context:(id<NSObject>)context {
   return [CKBackgroundLayoutComponent
       newWithComponent:
-   [CKFlexboxComponent
+          [CKFlexboxComponent newWithView:{}
-    newWithView:{
-    }
               size:{}
               style:{}
-    children: {
+              children:{
-      {
+                           {[CKButtonComponent
-        [CKButtonComponent
                                newWithAction:nil
                                      options:{
                                                  .titles = @"Purple",
-           .titleColors = UIColor.purpleColor,
+                                                 .titleColors =
-         }
+                                                     UIColor.purpleColor,
-         ]
+                                             }]},
-      },
+                           {[CKButtonComponent
-      {
-        [CKButtonComponent
                                newWithAction:nil
                                      options:{
                                                  .titles = @"Brown",
-           .titleColors = UIColor.brownColor,
+                                                 .titleColors =
-         }
+                                                     UIColor.brownColor,
-         ]
+                                             }]},
-      },
+                           {[CKButtonComponent
-      {
-        [CKButtonComponent
                                newWithAction:nil
                                      options:{
                                                  .titles = @"Cyan",
-           .titleColors = UIColor.cyanColor,
+                                                 .titleColors =
-         }
+                                                     UIColor.cyanColor,
-         ]
+                                             }]},
-      },
                        }]
-   background:
+            background:[CKImageComponent
-   [CKImageComponent
                            newWithImage:[UIImage imageNamed:@"sonarpattern"]
                              attributes:{}
                                    size:{}]];

iOS/Sample/UserDefaultsViewController.m

@@ -8,14 +8,14 @@
 #import "UserDefaultsViewController.h"
 
 @interface UserDefaultsViewController ()
-@property (weak, nonatomic) IBOutlet UITextField *valueTextField;
+@property(weak, nonatomic) IBOutlet UITextField* valueTextField;
-@property (weak, nonatomic) IBOutlet UITextField *keyTextField;
+@property(weak, nonatomic) IBOutlet UITextField* keyTextField;
-@property (nonatomic, strong) NSUserDefaults *userDefaults;
+@property(nonatomic, strong) NSUserDefaults* userDefaults;
 @end
 
 @implementation UserDefaultsViewController
 
-- (instancetype)initWithCoder:(NSCoder *)aDecoder {
+- (instancetype)initWithCoder:(NSCoder*)aDecoder {
   if (self = [super initWithCoder:aDecoder]) {
     _userDefaults = [[NSUserDefaults alloc] initWithSuiteName:nil];
   }
@@ -23,7 +23,8 @@
 }
 
 - (IBAction)tappedSave:(id)sender {
-    [self.userDefaults setObject:self.valueTextField.text forKey:self.keyTextField.text];
+  [self.userDefaults setObject:self.valueTextField.text
+                        forKey:self.keyTextField.text];
 }
 
 @end

iOS/Sample/main.m

@@ -9,8 +9,9 @@
 
 #import "AppDelegate.h"
 
-int main(int argc, char * argv[]) {
+int main(int argc, char* argv[]) {
   @autoreleasepool {
-      return UIApplicationMain(argc, argv, nil, NSStringFromClass([AppDelegate class]));
+    return UIApplicationMain(
+        argc, argv, nil, NSStringFromClass([AppDelegate class]));
   }
 }