jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix fresco fetch bug

Browse Source 
Summary: Before this diff the "getAllImageData" wasn't triggered as the it used to early exit, because persistedState was not null. That check was unnecessary and not needed.

Reviewed By: jknoxville

Differential Revision: D16377134

fbshipit-source-id: 61ee49fbd908733798086206a82e38890ecd0af6
This commit is contained in:
Pritesh Nandgaonkar
2019-07-19 07:26:45 -07:00
committed by Facebook Github Bot
parent e8a8f87086
commit 0c0f0d4a90
1 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/fresco/index.js
View File

@@ -97,9 +97,6 @@ export default class extends FlipperPlugin<PluginState, *, PersistedState> {
persistedState: ?PersistedState, persistedState: ?PersistedState,
store: ?MiddlewareAPI, store: ?MiddlewareAPI,
): Promise<?PersistedState> => { ): Promise<?PersistedState> => {
if (persistedState) {
return Promise.resolve(persistedState);
}
const defaultPromise = Promise.resolve(persistedState); const defaultPromise = Promise.resolve(persistedState);
if (!store) { if (!store) {
return defaultPromise; return defaultPromise;
@@ -110,8 +107,10 @@ export default class extends FlipperPlugin<PluginState, *, PersistedState> {
} }
const {levels, events, imageDataList} = data; const {levels, events, imageDataList} = data;
let pluginData: PersistedState = { let pluginData: PersistedState = {
...FlipperPlugin.defaultPersistedState, ...persistedState,
images: [...levels.levels], images: persistedState
? [...persistedState.images, ...levels.levels]
: levels.levels,
closeableReferenceLeaks: closeableReferenceLeaks:
(persistedState && persistedState.closeableReferenceLeaks) || [], (persistedState && persistedState.closeableReferenceLeaks) || [],
}; };