From 0c0f0d4a90c6b2db7c3574e97e9def9e83062af3 Mon Sep 17 00:00:00 2001 From: Pritesh Nandgaonkar Date: Fri, 19 Jul 2019 07:26:45 -0700 Subject: [PATCH] Fix fresco fetch bug Summary: Before this diff the "getAllImageData" wasn't triggered as the it used to early exit, because persistedState was not null. That check was unnecessary and not needed. Reviewed By: jknoxville Differential Revision: D16377134 fbshipit-source-id: 61ee49fbd908733798086206a82e38890ecd0af6 --- src/plugins/fresco/index.js | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/plugins/fresco/index.js b/src/plugins/fresco/index.js index cc00cfd6f..abad6a32c 100644 --- a/src/plugins/fresco/index.js +++ b/src/plugins/fresco/index.js @@ -97,9 +97,6 @@ export default class extends FlipperPlugin { persistedState: ?PersistedState, store: ?MiddlewareAPI, ): Promise => { - if (persistedState) { - return Promise.resolve(persistedState); - } const defaultPromise = Promise.resolve(persistedState); if (!store) { return defaultPromise; @@ -110,8 +107,10 @@ export default class extends FlipperPlugin { } const {levels, events, imageDataList} = data; let pluginData: PersistedState = { - ...FlipperPlugin.defaultPersistedState, - images: [...levels.levels], + ...persistedState, + images: persistedState + ? [...persistedState.images, ...levels.levels] + : levels.levels, closeableReferenceLeaks: (persistedState && persistedState.closeableReferenceLeaks) || [], };