From 0ab1aeee78075bf407ae6461740378bd45dbdfe3 Mon Sep 17 00:00:00 2001
From: Lorenzo Blasa <lblasa@meta.com>
Date: Wed, 26 Jul 2023 08:16:47 -0700
Subject: [PATCH] ClientQuery optional for commands

Summary:
Some commands are run without a ClientQuery i.e. fetching devices.

Nevertheless, this can be provide insights when problems take place.

Reviewed By: antonk52

Differential Revision: D47795358

fbshipit-source-id: 0b7dc34475ae061f1b72843a087a798d305ed1c8
---
 desktop/flipper-server-core/src/recorder.tsx | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/desktop/flipper-server-core/src/recorder.tsx b/desktop/flipper-server-core/src/recorder.tsx
index 7ceb024e7..1b7e41f0d 100644
--- a/desktop/flipper-server-core/src/recorder.tsx
+++ b/desktop/flipper-server-core/src/recorder.tsx
@@ -33,15 +33,20 @@ class Recorder {
 
   private handler_ = {
     cmd: (payload: CommandEventPayload) => {
-      if (this.flipperServer && payload.context) {
-        const clientQuery = payload.context as ClientQuery;
+      if (this.flipperServer) {
+        const clientQuery = payload.context as ClientQuery | undefined;
+
+        const device = clientQuery?.device ?? 'NONE';
+        const app = clientQuery?.app ?? 'NONE';
+        const medium = clientQuery?.medium ?? 'NONE';
+
         const entry: CommandRecordEntry = {
           time: new Date(),
           type: 'cmd',
-          device: clientQuery.device,
-          app: clientQuery.app,
+          device,
+          app,
           message: payload.cmd,
-          medium: clientQuery.medium,
+          medium,
           cmd: payload.cmd,
           description: payload.description,
           success: payload.success,