jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Back out "Back out "[flipper][js] JS apps support 1/n""

Browse Source 
Summary:
Original commit changeset: ff84080d43fa

This re-adds JS client support. The original version had a small bug that inadvertantly wrapped support for Android emulators in the dropdown in a GK that was only meant to cover JS clients. This is addressed here.

Reviewed By: timur-valiev

Differential Revision: D18707485

fbshipit-source-id: ceea8e279a21111f96073f8b784e852f6313e2a4
This commit is contained in:
Pascal Hartig
2019-11-26 08:07:29 -08:00
committed by Facebook Github Bot
parent e99f2bcd8b
commit 0a7c57f5a0
10 changed files with 499 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/devices/BaseDevice.tsx
View File

@@ -52,7 +52,7 @@ export type DeviceExport = {
logs: Array<DeviceLogEntry>;
};
export type OS = 'iOS' | 'Android' | 'Windows' | 'MacOS';
export type OS = 'iOS' | 'Android' | 'Windows' | 'MacOS' | 'JSWebApp';
export default class BaseDevice {
constructor(serial: string, deviceType: DeviceType, title: string, os: OS) {

20
src/devices/JSDevice.tsx Normal file
View File

@@ -0,0 +1,20 @@
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @format
*/
import BaseDevice from './BaseDevice';
export default class JSDevice extends BaseDevice {
webContentsId: number;
constructor(serial: string, title: string, webContentsId: number) {
super(serial, 'emulator', title, 'JSWebApp');
this.devicePlugins = [];
this.webContentsId = webContentsId;
}
}