From 0a79118ee742401289312827f82ae44d3a34f19d Mon Sep 17 00:00:00 2001 From: Anton Nikolaev Date: Mon, 6 Apr 2020 11:08:34 -0700 Subject: [PATCH] Fix bumping podspecs in "Getting Started" docs in prepare-release.sh Summary: Fixed bumping podspecs in "Getting Started" docs in prepare-release.sh Reviewed By: mweststrate Differential Revision: D20869684 fbshipit-source-id: 78a3b7064de51dbd8ca505db863595726d038326 --- docs/getting-started/react-native-ios.md | 4 ++-- scripts/prepare-release.sh | 15 ++++++++++----- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/docs/getting-started/react-native-ios.md b/docs/getting-started/react-native-ios.md index d0e23877f..4cbfdda25 100644 --- a/docs/getting-started/react-native-ios.md +++ b/docs/getting-started/react-native-ios.md @@ -16,7 +16,7 @@ Add this code to your `ios/Podfile`: platform :ios, '9.0' def flipper_pods() - flipperkit_version = '0.35.0' + flipperkit_version = '0.36.0' pod 'FlipperKit', '~>' + flipperkit_version, :configuration => 'Debug' pod 'FlipperKit/FlipperKitLayoutPlugin', '~>' + flipperkit_version, :configuration => 'Debug' pod 'FlipperKit/SKIOSNetworkPlugin', '~>' + flipperkit_version, :configuration => 'Debug' @@ -174,4 +174,4 @@ If you can't build your app after adding Flipper, you may need to configure the ## Further Steps -To create your own plugins and integrate with Flipper using JavaScript, check out our [writing plugins for React Native](tutorial/react-native) tutorial! \ No newline at end of file +To create your own plugins and integrate with Flipper using JavaScript, check out our [writing plugins for React Native](tutorial/react-native) tutorial! diff --git a/scripts/prepare-release.sh b/scripts/prepare-release.sh index aef4dad08..e1cb815c5 100755 --- a/scripts/prepare-release.sh +++ b/scripts/prepare-release.sh @@ -46,7 +46,8 @@ DESKTOP_DIR="$SONAR_DIR/desktop" FLIPPERKIT_PODSPEC_PATH="$SONAR_DIR/FlipperKit.podspec" FLIPPER_PODSPEC_PATH="$SONAR_DIR/Flipper.podspec" TUTORIAL_PODFILE_PATH="$SONAR_DIR/iOS/Tutorial/Podfile" -SONAR_GETTING_STARTED_DOC="$SONAR_DIR/docs/getting-started.md" +IOS_GETTING_STARTED_DOC="$SONAR_DIR/docs/getting-started/ios-native.md" +RN_IOS_GETTING_STARTED_DOC="$SONAR_DIR/docs/getting-started/react-native-ios.md" SPECS_DIR="$SONAR_DIR/Specs/" FLIPPERKIT_VERSION_TAG='flipperkit_version' OLD_VERSION_POD_ARG=$(< "$FLIPPER_PODSPEC_PATH" grep "$FLIPPERKIT_VERSION_TAG =" ) @@ -90,16 +91,20 @@ if $darwin; then sed -i '' "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$FLIPPERKIT_PODSPEC_PATH" echo "Updating $FLIPPER_PODSPEC_PATH" sed -i '' "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$FLIPPER_PODSPEC_PATH" -echo "Updating $SONAR_GETTING_STARTED_DOC" -sed -i '' "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$SONAR_GETTING_STARTED_DOC" +echo "Updating $IOS_GETTING_STARTED_DOC" +sed -i '' "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$IOS_GETTING_STARTED_DOC" +echo "Updating $RN_IOS_GETTING_STARTED_DOC" +sed -i '' "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$RN_IOS_GETTING_STARTED_DOC" echo "Updating $TUTORIAL_PODFILE_PATH" sed -i '' "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$TUTORIAL_PODFILE_PATH" else sed -i "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$FLIPPERKIT_PODSPEC_PATH" echo "Updating $FLIPPER_PODSPEC_PATH" sed -i "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$FLIPPER_PODSPEC_PATH" - echo "Updating $SONAR_GETTING_STARTED_DOC" - sed -i "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$SONAR_GETTING_STARTED_DOC" + echo "Updating $IOS_GETTING_STARTED_DOC" + sed -i "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$IOS_GETTING_STARTED_DOC" + echo "Updating $RN_IOS_GETTING_STARTED_DOC" + sed -i "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$RN_IOS_GETTING_STARTED_DOC" echo "Updating $TUTORIAL_PODFILE_PATH" sed -i "s/${FLIPPERKIT_VERSION_TAG} = ${OLD_VERSION}/${FLIPPERKIT_VERSION_TAG} = '${VERSION}'/" "$TUTORIAL_PODFILE_PATH" fi