Upgrading flow and fixing lint errors
Summary: Upgrading to flow 0.91, fixing a bunch of `$FloxFixMe`s that were introduced by upgrading to 0.86. Also fixing some linting issues. Reviewed By: priteshrnandgaonkar Differential Revision: D13900794 fbshipit-source-id: 5d0a1b62371f3b5d34b909bae0876583acb6f977
This commit is contained in:
committed by
Facebook Github Bot
parent
88cc299811
commit
09a93cd9e6
@@ -28,22 +28,22 @@ const DropdownButton = styled(Button)({
|
||||
fontSize: 11,
|
||||
});
|
||||
|
||||
// Remove this if the flow fixme at the bottom is addressed (or has already been removed).
|
||||
/* eslint-disable prettier/prettier */
|
||||
class DevicesButton extends Component<Props> {
|
||||
launchEmulator = (name: string) => {
|
||||
// On Linux, you must run the emulator from the directory it's in because
|
||||
// reasons ...
|
||||
whichPromise('emulator').then(emulatorPath => {
|
||||
const child = spawn(emulatorPath, [`@${name}`], {
|
||||
detached: true,
|
||||
cwd: dirname(emulatorPath),
|
||||
});
|
||||
child.stderr.on('data', data => {
|
||||
console.error(`Android emulator error: ${data}`);
|
||||
});
|
||||
child.on('error', console.error);
|
||||
}).catch(console.error);
|
||||
whichPromise('emulator')
|
||||
.then(emulatorPath => {
|
||||
const child = spawn(emulatorPath, [`@${name}`], {
|
||||
detached: true,
|
||||
cwd: dirname(emulatorPath),
|
||||
});
|
||||
child.stderr.on('data', data => {
|
||||
console.error(`Android emulator error: ${data}`);
|
||||
});
|
||||
child.on('error', console.error);
|
||||
})
|
||||
.catch(console.error);
|
||||
this.props.preferDevice(name);
|
||||
};
|
||||
|
||||
@@ -109,10 +109,8 @@ class DevicesButton extends Component<Props> {
|
||||
</DropdownButton>
|
||||
);
|
||||
}
|
||||
} /* $FlowFixMe(>=0.86.0) This comment suppresses an error found when Flow v0.86
|
||||
* was deployed. To see the error, delete this comment and run Flow.
|
||||
*/
|
||||
export default connect(
|
||||
}
|
||||
export default connect<Props, {||}, _, _, _, _>(
|
||||
({connections: {devices, androidEmulators, selectedDevice}}) => ({
|
||||
devices,
|
||||
androidEmulators,
|
||||
|
||||
Reference in New Issue
Block a user