Upgrading flow and fixing lint errors

Summary:
Upgrading to flow 0.91, fixing a bunch of `$FloxFixMe`s that were introduced by upgrading to 0.86.
Also fixing some linting issues.

Reviewed By: priteshrnandgaonkar

Differential Revision: D13900794

fbshipit-source-id: 5d0a1b62371f3b5d34b909bae0876583acb6f977

src/NotificationsHub.js

@@ -98,24 +98,28 @@ export default class Notifications extends FlipperDevicePlugin<{}> {
   }
 }
 
-type Props = {|
+type OwnProps = {|
   ...SearchableProps,
+  onClear: () => void,
+  selectedID: ?string,
+  logger: Logger,
+|};
+
+type Props = {|
+  ...OwnProps,
   activeNotifications: Array<PluginNotification>,
   invalidatedNotifications: Array<PluginNotification>,
   blacklistedPlugins: Array<string>,
   blacklistedCategories: Array<string>,
   devicePlugins: Map<string, Class<FlipperDevicePlugin<>>>,
   clientPlugins: Map<string, Class<FlipperPlugin<>>>,
-  onClear: () => void,
   updatePluginBlacklist: (blacklist: Array<string>) => mixed,
   updateCategoryBlacklist: (blacklist: Array<string>) => mixed,
-  selectPlugin: ({
+  selectPlugin: (payload: {|
     selectedPlugin: ?string,
     selectedApp: ?string,
-    deepLinkPayload?: ?string,
-  }) => mixed,
-  selectedID: ?string,
-  logger: Logger,
+    deepLinkPayload: ?string,
+  |}) => mixed,
 |};
 
 type State = {|
@@ -322,11 +326,7 @@ class NotificationsTable extends Component<Props, State> {
   }
 }
 
-/* $FlowFixMe(>=0.86.0) This
- * comment suppresses an error found when Flow v0.86 was
- * deployed. To see the error, delete this comment and
- * run Flow. */
-const ConnectedNotificationsTable = connect(
+const ConnectedNotificationsTable = connect<Props, OwnProps, _, _, _, _>(
   ({
     notifications: {
       activeNotifications,
@@ -343,6 +343,7 @@ const ConnectedNotificationsTable = connect(
     devicePlugins,
     clientPlugins,
   }),
+  // $FlowFixMe
   {
     updatePluginBlacklist,
     updateCategoryBlacklist,
@@ -453,11 +454,11 @@ type ItemProps = {
   onHideCategory?: () => mixed,
   isSelected?: boolean,
   inactive?: boolean,
-  selectPlugin?: ({
+  selectPlugin?: (payload: {|
     selectedPlugin: ?string,
     selectedApp: ?string,
-    deepLinkPayload?: ?string,
-  }) => mixed,
+    deepLinkPayload: ?string,
+  |}) => mixed,
   logger?: Logger,
   plugin: ?Class<FlipperBasePlugin<>>,
 };