Reload single plugin on auto-update

Summary: Implemented a way for re-loading single plugin on auto-update. This make it possible to apply update without full Flipper restart.

Reviewed By: mweststrate

Differential Revision: D23729972

fbshipit-source-id: ed30f7cde5a0537945db0b5bb6969ae8fde42cb6

desktop/app/src/dispatcher/__tests__/plugins.node.tsx

@@ -13,7 +13,7 @@ import dispatcher, {
   getDynamicPlugins,
   checkDisabled,
   checkGK,
-  requirePlugin,
+  createRequirePluginFunction,
   filterNewestVersionOfEachPlugin,
 } from '../plugins';
 import {PluginDetails} from 'flipper-plugin-lib';
@@ -136,7 +136,7 @@ test('checkGK for failing plugin', () => {
 });
 
 test('requirePlugin returns null for invalid requires', () => {
-  const requireFn = requirePlugin([], {}, require);
+  const requireFn = createRequirePluginFunction([], require);
   const plugin = requireFn({
     ...samplePluginDetails,
     name: 'pluginID',
@@ -149,7 +149,7 @@ test('requirePlugin returns null for invalid requires', () => {
 
 test('requirePlugin loads plugin', () => {
   const name = 'pluginID';
-  const requireFn = requirePlugin([], {}, require);
+  const requireFn = createRequirePluginFunction([], require);
   const plugin = requireFn({
     ...samplePluginDetails,
     name,
@@ -236,7 +236,7 @@ test('bundled versions are used when env var FLIPPER_DISABLE_PLUGIN_AUTO_UPDATE
 
 test('requirePlugin loads valid Sandy plugin', () => {
   const name = 'pluginID';
-  const requireFn = requirePlugin([], {}, require);
+  const requireFn = createRequirePluginFunction([], require);
   const plugin = requireFn({
     ...samplePluginDetails,
     name,
@@ -270,7 +270,7 @@ test('requirePlugin loads valid Sandy plugin', () => {
 test('requirePlugin errors on invalid Sandy plugin', () => {
   const name = 'pluginID';
   const failedPlugins: any[] = [];
-  const requireFn = requirePlugin(failedPlugins, {}, require);
+  const requireFn = createRequirePluginFunction(failedPlugins, require);
   requireFn({
     ...samplePluginDetails,
     name,
@@ -286,7 +286,7 @@ test('requirePlugin errors on invalid Sandy plugin', () => {
 
 test('requirePlugin loads valid Sandy Device plugin', () => {
   const name = 'pluginID';
-  const requireFn = requirePlugin([], {}, require);
+  const requireFn = createRequirePluginFunction([], require);
   const plugin = requireFn({
     ...samplePluginDetails,
     name,

desktop/app/src/dispatcher/plugins.tsx

@@ -37,7 +37,9 @@ import loadDynamicPlugins from '../utils/loadDynamicPlugins';
 import Immer from 'immer';
 
 // eslint-disable-next-line import/no-unresolved
-import getPluginIndex from '../utils/getDefaultPluginsIndex';
+import getDefaultPluginsIndex from '../utils/getDefaultPluginsIndex';
+
+let defaultPluginsIndex: any = null;
 
 export default async (store: Store, logger: Logger) => {
   // expose Flipper and exact globally for dynamically loaded plugins
@@ -53,7 +55,7 @@ export default async (store: Store, logger: Logger) => {
   const disabledPlugins: Array<PluginDetails> = [];
   const failedPlugins: Array<[PluginDetails, string]> = [];
 
-  const defaultPluginsIndex = getPluginIndex();
+  defaultPluginsIndex = getDefaultPluginsIndex();
 
   const initialPlugins: PluginDefinition[] = filterNewestVersionOfEachPlugin(
     getBundledPlugins(),
@@ -62,7 +64,7 @@ export default async (store: Store, logger: Logger) => {
     .map(reportVersion)
     .filter(checkDisabled(disabledPlugins))
     .filter(checkGK(gatekeepedPlugins))
-    .map(requirePlugin(failedPlugins, defaultPluginsIndex))
+    .map(createRequirePluginFunction(failedPlugins))
     .filter(notNull);
 
   store.dispatch(addGatekeepedPlugins(gatekeepedPlugins));
@@ -173,18 +175,13 @@ export const checkDisabled = (disabledPlugins: Array<PluginDetails>) => (
   return !disabledList.has(plugin.name);
 };
 
-export const requirePlugin = (
+export const createRequirePluginFunction = (
   failedPlugins: Array<[PluginDetails, string]>,
-  defaultPluginsIndex: any,
   reqFn: Function = global.electronRequire,
 ) => {
   return (pluginDetails: PluginDetails): PluginDefinition | null => {
     try {
-      return tryCatchReportPluginFailures(
-        () => requirePluginInternal(pluginDetails, defaultPluginsIndex, reqFn),
-        'plugin:load',
-        pluginDetails.id,
-      );
+      return requirePlugin(pluginDetails, reqFn);
     } catch (e) {
       failedPlugins.push([pluginDetails, e.message]);
       console.error(`Plugin ${pluginDetails.id} failed to load`, e);
@@ -193,15 +190,24 @@ export const requirePlugin = (
   };
 };
 
+export const requirePlugin = (
+  pluginDetails: PluginDetails,
+  reqFn: Function = global.electronRequire,
+): PluginDefinition => {
+  return tryCatchReportPluginFailures(
+    () => requirePluginInternal(pluginDetails, reqFn),
+    'plugin:load',
+    pluginDetails.id,
+  );
+};
+
 const requirePluginInternal = (
   pluginDetails: PluginDetails,
-  defaultPluginsIndex: any,
   reqFn: Function = global.electronRequire,
-) => {
+): PluginDefinition => {
   let plugin = pluginDetails.isDefault
     ? defaultPluginsIndex[pluginDetails.name]
     : reqFn(pluginDetails.entry);
-
   if (pluginDetails.flipperSDKVersion) {
     // Sandy plugin
     return new SandyPluginDefinition(pluginDetails, plugin);