From 095a2b640b41934c5bc903ffed3c618e5662c777 Mon Sep 17 00:00:00 2001
From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com>
Date: Mon, 29 Mar 2021 10:46:41 -0700
Subject: [PATCH] Bump socket.io from 3.1.0 to 4.0.0 in /desktop (#2132)

Summary:
Bumps [socket.io](https://github.com/socketio/socket.io) from 3.1.0 to 4.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/releases">socket.io's releases</a>.</em></p>
<blockquote>
<h2>4.0.0</h2>
<p>Blog post: <a href="https://socket.io/blog/socket-io-4-release/">https://socket.io/blog/socket-io-4-release/</a>
Migration guide: <a href="https://socket.io/docs/v3/migrating-from-3-x-to-4-0/">https://socket.io/docs/v3/migrating-from-3-x-to-4-0/</a></p>
<h3>Bug Fixes</h3>
<ul>
<li>make io.to(...) immutable (<a href="https://github.com/socketio/socket.io/commit/ac9e8ca6c71e00d4af45ee03f590fe56f3951186">ac9e8ca</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>add some utility methods (<a href="https://github.com/socketio/socket.io/commit/b25495c069031674da08e19aed68922c7c7a0e28">b25495c</a>)</li>
<li>add support for typed events (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3822">#3822</a>) (<a href="https://github.com/socketio/socket.io/commit/0107510ba8a0f148c78029d8be8919b350feb633">0107510</a>)</li>
<li>allow to exclude specific rooms when broadcasting (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3789">#3789</a>) (<a href="https://github.com/socketio/socket.io/commit/7de2e87e888d849eb2dfc5e362af4c9e86044701">7de2e87</a>)</li>
<li>allow to pass an array to io.to(...) (<a href="https://github.com/socketio/socket.io/commit/085d1de9df909651de8b313cc6f9f253374b702e">085d1de</a>)</li>
</ul>
<h3>BREAKING CHANGES</h3>
<ul>
<li><code>io.to(...)</code> now returns an immutable operator</li>
</ul>
<p>Previously, broadcasting to a given room (by calling <code>io.to()</code>) would mutate the io instance, which could lead to surprising behaviors, like:</p>
<pre lang="js"><code>io.to(&quot;room1&quot;);
io.to(&quot;room2&quot;).emit(/* ... */); // also sent to room1
<p>// or with async/await
io.to(&quot;room3&quot;).emit(&quot;details&quot;, await fetchDetails()); // random behavior: maybe in room3, maybe to all clients
</code></pre></p>
<p>Calling <code>io.to()</code> (or any other broadcast modifier) will now return an immutable instance.</p>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/3.1.2...4.0.0">https://github.com/socketio/socket.io/compare/3.1.2...4.0.0</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/4.0.0">4.0.0</a></li>
<li>engine.io version:  <code>~5.0.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>
<h2>3.1.2</h2>
<h3>Bug Fixes</h3>
<ul>
<li>ignore packets received after disconnection (<a href="https://github.com/socketio/socket.io/commit/494c64e44f645cbd24c645f1186d203789e84af0">494c64e</a>)</li>
</ul>
<h4>Links:</h4>
<ul>
<li>Diff: <a href="https://github.com/socketio/socket.io/compare/3.1.1...3.1.2">https://github.com/socketio/socket.io/compare/3.1.1...3.1.2</a></li>
<li>Client release: <a href="https://github.com/socketio/socket.io-client/releases/tag/3.1.2">3.1.2</a></li>
<li>engine.io version:  <code>~4.1.0</code></li>
<li>ws version: <code>~7.4.2</code></li>
</ul>

</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/socketio/socket.io/blob/master/CHANGELOG.md">socket.io's changelog</a>.</em></p>
<blockquote>
<h1><a href="https://github.com/socketio/socket.io/compare/3.1.2...4.0.0">4.0.0</a> (2021-03-10)</h1>
<h3>Bug Fixes</h3>
<ul>
<li>make io.to(...) immutable (<a href="https://github.com/socketio/socket.io/commit/ac9e8ca6c71e00d4af45ee03f590fe56f3951186">ac9e8ca</a>)</li>
</ul>
<h3>Features</h3>
<ul>
<li>add some utility methods (<a href="https://github.com/socketio/socket.io/commit/b25495c069031674da08e19aed68922c7c7a0e28">b25495c</a>)</li>
<li>add support for typed events (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3822">#3822</a>) (<a href="https://github.com/socketio/socket.io/commit/0107510ba8a0f148c78029d8be8919b350feb633">0107510</a>)</li>
<li>allow to exclude specific rooms when broadcasting (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3789">#3789</a>) (<a href="https://github.com/socketio/socket.io/commit/7de2e87e888d849eb2dfc5e362af4c9e86044701">7de2e87</a>)</li>
<li>allow to pass an array to io.to(...) (<a href="https://github.com/socketio/socket.io/commit/085d1de9df909651de8b313cc6f9f253374b702e">085d1de</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/socket.io/compare/3.1.1...3.1.2">3.1.2</a> (2021-02-26)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>ignore packets received after disconnection (<a href="https://github.com/socketio/socket.io/commit/494c64e44f645cbd24c645f1186d203789e84af0">494c64e</a>)</li>
</ul>
<h2><a href="https://github.com/socketio/socket.io/compare/3.1.0...3.1.1">3.1.1</a> (2021-02-03)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>properly parse the CONNECT packet in v2 compatibility mode (<a href="https://github.com/socketio/socket.io/commit/6f4bd7f8e7c41a075a8014565330a77c38b03a8d">6f4bd7f</a>)</li>
<li><strong>typings:</strong> add return types and general-case overload signatures (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3776">#3776</a>) (<a href="https://github.com/socketio/socket.io/commit/9e8f288ca9f14f91064b8d3cce5946f7d23d407c">9e8f288</a>)</li>
<li><strong>typings:</strong> update the types of &quot;query&quot;, &quot;auth&quot; and &quot;headers&quot; (<a href="https://github.com/socketio/socket.io/commit/4f2e9a716d9835b550c8fd9a9b429ebf069c2895">4f2e9a7</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/socketio/socket.io/commit/5eaeffc8e2244b73dd13fd2562c9684ad289997b"><code>5eaeffc</code></a> chore(release): 4.0.0</li>
<li><a href="https://github.com/socketio/socket.io/commit/1b6d6de4ed99da1747641972a6034dbc23415d0e"><code>1b6d6de</code></a> chore: include Engine.IO v5</li>
<li><a href="https://github.com/socketio/socket.io/commit/0107510ba8a0f148c78029d8be8919b350feb633"><code>0107510</code></a> feat: add support for typed events (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3822">#3822</a>)</li>
<li><a href="https://github.com/socketio/socket.io/commit/b25495c069031674da08e19aed68922c7c7a0e28"><code>b25495c</code></a> feat: add some utility methods</li>
<li><a href="https://github.com/socketio/socket.io/commit/085d1de9df909651de8b313cc6f9f253374b702e"><code>085d1de</code></a> feat: allow to pass an array to io.to(...)</li>
<li><a href="https://github.com/socketio/socket.io/commit/ac9e8ca6c71e00d4af45ee03f590fe56f3951186"><code>ac9e8ca</code></a> fix: make io.to(...) immutable</li>
<li><a href="https://github.com/socketio/socket.io/commit/7de2e87e888d849eb2dfc5e362af4c9e86044701"><code>7de2e87</code></a> feat: allow to exclude specific rooms when broadcasting (<a href="https://github-redirect.dependabot.com/socketio/socket.io/issues/3789">#3789</a>)</li>
<li><a href="https://github.com/socketio/socket.io/commit/225ade062a13030164f89356b0a41f28203c3458"><code>225ade0</code></a> chore(release): 3.1.2</li>
<li><a href="https://github.com/socketio/socket.io/commit/494c64e44f645cbd24c645f1186d203789e84af0"><code>494c64e</code></a> fix: ignore packet received after disconnection</li>
<li><a href="https://github.com/socketio/socket.io/commit/67a61e39e65f26c9c19b7ddaed8845e8c09e4e84"><code>67a61e3</code></a> chore: loosen the version requirement of types/node</li>
<li>Additional commits viewable in <a href="https://github.com/socketio/socket.io/compare/3.1.0...4.0.0">compare view</a></li>
</ul>
</details>
<br />

[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=socket.io&package-manager=npm_and_yarn&previous-version=3.1.0&new-version=4.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

 ---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `dependabot rebase` will rebase this PR
- `dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `dependabot merge` will merge this PR after your CI passes on it
- `dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `dependabot cancel merge` will cancel a previously requested merge and block automerging
- `dependabot reopen` will reopen this PR if it is closed
- `dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

Pull Request resolved: https://github.com/facebook/flipper/pull/2132

Reviewed By: passy

Differential Revision: D27396028

Pulled By: mweststrate

fbshipit-source-id: 26543b1dd2f984f0425d80947d174ab60521e8e4
---
 desktop/package.json |  2 +-
 desktop/yarn.lock    | 48 ++++++++++++++++++--------------------------
 2 files changed, 20 insertions(+), 30 deletions(-)

diff --git a/desktop/package.json b/desktop/package.json
index 4c9b377af..1169070dd 100644
--- a/desktop/package.json
+++ b/desktop/package.json
@@ -180,7 +180,7 @@
     "recursive-readdir": "^2.2.2",
     "redux": "^4.0.0",
     "rimraf": "^3.0.2",
-    "socket.io": "^3.1.0",
+    "socket.io": "^4.0.0",
     "tmp": "^0.2.1",
     "ts-jest": "^26.0.0",
     "ts-node": "^8.8.1",
diff --git a/desktop/yarn.lock b/desktop/yarn.lock
index e565bfd6e..7d85e4aa7 100644
--- a/desktop/yarn.lock
+++ b/desktop/yarn.lock
@@ -2682,20 +2682,10 @@
     "@types/node" "*"
     form-data "^3.0.0"
 
-"@types/node@*", "@types/node@^14.14.10":
-  version "14.14.31"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.31.tgz#72286bd33d137aa0d152d47ec7c1762563d34055"
-  integrity sha512-vFHy/ezP5qI0rFgJ7aQnjDXwAMrG0KqqIH7tQG5PPv3BWBayOPIQNBjVc/P6hhdZfMx51REc6tfDNXHUio893g==
-
-"@types/node@^14.14.36":
-  version "14.14.36"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.36.tgz#5637905dbb15c30a33a3c65b9ef7c20e3c85ebad"
-  integrity sha512-kjivUwDJfIjngzbhooRnOLhGYz6oRFi+L+EpMjxroDYXwDw9lHrJJ43E+dJ6KAd3V3WxWAJ/qZE9XKYHhjPOFQ==
-
-"@types/node@^14.6.2":
-  version "14.14.35"
-  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.35.tgz#42c953a4e2b18ab931f72477e7012172f4ffa313"
-  integrity sha512-Lt+wj8NVPx0zUmUwumiVXapmaLUcAk3yPuHCFVXras9k5VT9TdhJqKqGVUQCD60OTMCl0qxJ57OiTL0Mic3Iag==
+"@types/node@*", "@types/node@>=10.0.0", "@types/node@^14.14.36", "@types/node@^14.6.2":
+  version "14.14.37"
+  resolved "https://registry.yarnpkg.com/@types/node/-/node-14.14.37.tgz#a3dd8da4eb84a996c36e331df98d82abd76b516e"
+  integrity sha512-XYmBiy+ohOR4Lh5jE379fV2IU+6Jn4g5qASinhitfyO71b/sCo6MKsMLF5tc7Zf2CE8hViVQyYSobJNke8OvUw==
 
 "@types/normalize-package-data@^2.4.0":
   version "2.4.0"
@@ -5780,10 +5770,10 @@ engine.io-parser@~4.0.0:
   dependencies:
     base64-arraybuffer "0.1.4"
 
-engine.io@~4.1.0:
-  version "4.1.0"
-  resolved "https://registry.yarnpkg.com/engine.io/-/engine.io-4.1.0.tgz#d8ac90a09ed9fc703abf87023f1e1815e33f044e"
-  integrity sha512-vW7EAtn0HDQ4MtT5QbmCHF17TaYLONv2/JwdYsq9USPRZVM4zG7WB3k0Nc321z8EuSOlhGokrYlYx4176QhD0A==
+engine.io@~5.0.0:
+  version "5.0.0"
+  resolved "https://registry.yarnpkg.com/engine.io/-/engine.io-5.0.0.tgz#470dc94a8a4907fa4d2cd1fa6611426afcee61bf"
+  integrity sha512-BATIdDV3H1SrE9/u2BAotvsmjJg0t1P4+vGedImSs1lkFAtQdvk4Ev1y4LDiPF7BPWgXWEG+NDY+nLvW3UrMWw==
   dependencies:
     accepts "~1.3.4"
     base64id "2.0.0"
@@ -12410,10 +12400,10 @@ snapdragon@^0.8.1:
     source-map-resolve "^0.5.0"
     use "^3.1.0"
 
-socket.io-adapter@~2.1.0:
-  version "2.1.0"
-  resolved "https://registry.yarnpkg.com/socket.io-adapter/-/socket.io-adapter-2.1.0.tgz#edc5dc36602f2985918d631c1399215e97a1b527"
-  integrity sha512-+vDov/aTsLjViYTwS9fPy5pEtTkrbEKsw2M+oVSoFGw6OD1IpvlV1VPhUzNbofCQ8oyMbdYJqDtGdmHQK6TdPg==
+socket.io-adapter@~2.2.0:
+  version "2.2.0"
+  resolved "https://registry.yarnpkg.com/socket.io-adapter/-/socket.io-adapter-2.2.0.tgz#43af9157c4609e74b8addc6867873ac7eb48fda2"
+  integrity sha512-rG49L+FwaVEwuAdeBRq49M97YI3ElVabJPzvHT9S6a2CWhDKnjSFasvwAwSYPRhQzfn4NtDIbCaGYgOCOU/rlg==
 
 socket.io-parser@~4.0.3:
   version "4.0.4"
@@ -12424,19 +12414,19 @@ socket.io-parser@~4.0.3:
     component-emitter "~1.3.0"
     debug "~4.3.1"
 
-socket.io@^3.1.0:
-  version "3.1.0"
-  resolved "https://registry.yarnpkg.com/socket.io/-/socket.io-3.1.0.tgz#4f3accda31e95893f618090c9cb5e85d345421fb"
-  integrity sha512-Aqg2dlRh6xSJvRYK31ksG65q4kmBOqU4g+1ukhPcoT6wNGYoIwSYPlCPuRwOO9pgLUajojGFztl6+V2opmKcww==
+socket.io@^4.0.0:
+  version "4.0.0"
+  resolved "https://registry.yarnpkg.com/socket.io/-/socket.io-4.0.0.tgz#ee484a95dc6a38698491aaf63b6ec1f3ceeac0a8"
+  integrity sha512-/c1riZMV/4yz7KEpaMhDQbwhJDIoO55whXaRKgyEBQrLU9zUHXo9rzeTMvTOqwL9mbKfHKdrXcMoCeQ/1YtMsg==
   dependencies:
     "@types/cookie" "^0.4.0"
     "@types/cors" "^2.8.8"
-    "@types/node" "^14.14.10"
+    "@types/node" ">=10.0.0"
     accepts "~1.3.4"
     base64id "~2.0.0"
     debug "~4.3.1"
-    engine.io "~4.1.0"
-    socket.io-adapter "~2.1.0"
+    engine.io "~5.0.0"
+    socket.io-adapter "~2.2.0"
     socket.io-parser "~4.0.3"
 
 sort-keys@^4.0.0: