jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix improper plugin id assignment

Browse Source 
Summary: This diff fixes the improper plugin id getting assigned to the variable which lead to notifications not getting shown. The client id has `#` so pluginId is no longer the second argument when one splits the string by `#`. This diff fixes this problem.

Reviewed By: passy

Differential Revision: D13176776

fbshipit-source-id: cd5bdc33c61485e3cdc2f2dbcc615980c39c8b8c
This commit is contained in:
Pritesh Nandgaonkar
2018-11-23 05:46:27 -08:00
committed by Facebook Github Bot
parent 8327e1ff71
commit 08cdb5e2e8
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/dispatcher/notifications.js
View File

@@ -87,7 +87,9 @@ export default (store: Store, logger: Logger) => {
Object.keys(pluginStates).forEach(key => { Object.keys(pluginStates).forEach(key => {
if (knownPluginStates.get(key) !== pluginStates[key]) { if (knownPluginStates.get(key) !== pluginStates[key]) {
knownPluginStates.set(key, pluginStates[key]); knownPluginStates.set(key, pluginStates[key]);
const [client, pluginId] = key.split('#'); const split = key.split('#');
const pluginId = split.pop();
const client = split.join('#');
const persistingPlugin: ?Class<FlipperPlugin<>> = pluginMap.get( const persistingPlugin: ?Class<FlipperPlugin<>> = pluginMap.get(
pluginId, pluginId,
); );