rename fill attribute

Summary:
We were using `fill={true}` as an attribute to make flexbox containers fill the entire available space.

However, `fill` is an HTML attribute (see: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/fill) This caused warnings printed to the console.

This diff renames the attribute to `grow` with is also more in line with the Flexbox terminology.

Reviewed By: priteshrnandgaonkar

Differential Revision: D10488389

fbshipit-source-id: ed8553c6203cdf6df94d26c731164ecec4c9fbd2
This commit is contained in:
Daniel Büchele
2018-10-22 09:52:19 -07:00
committed by Facebook Github Bot
parent 2a179b9d3c
commit 086ab0188b
23 changed files with 41 additions and 43 deletions

View File

@@ -1120,7 +1120,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
} = this.state;
return (
<FlexColumn fill={true}>
<FlexColumn grow={true}>
<Toolbar>
<SearchIconContainer
onClick={this.onFindClick}
@@ -1197,7 +1197,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
</SearchIconContainer>
)}
</Toolbar>
<FlexRow fill={true}>
<FlexRow grow={true}>
{initialised ? (
<ElementsInspector
onElementSelected={this.onElementSelected}
@@ -1210,7 +1210,7 @@ export default class Layout extends FlipperPlugin<InspectorState> {
elements={elements}
/>
) : (
<Center fill={true}>
<Center grow={true}>
<LoadingIndicator />
</Center>
)}