Fix for button popup menus not rendering
Summary: The electron menu popup requires that the position be an integer. Somehow the y-position of the button in the title bar has been moved by half a pixel. Calling Math.floor on the returned values fixes this. Reviewed By: passy Differential Revision: D16936833 fbshipit-source-id: 6abb9add4288f1d64c051ba3e45519340ccbb56e
This commit is contained in:
committed by
Facebook Github Bot
parent
8699d62b47
commit
076087f0b2
@@ -285,8 +285,8 @@ class Button extends React.Component<Props, State> {
|
||||
const node = findDOMNode(current);
|
||||
if (node instanceof Element) {
|
||||
const {left, bottom} = node.getBoundingClientRect();
|
||||
position.x = left;
|
||||
position.y = bottom + 6;
|
||||
position.x = Math.floor(left);
|
||||
position.y = Math.floor(bottom) + 6;
|
||||
}
|
||||
}
|
||||
menu.popup({
|
||||
|
||||
Reference in New Issue
Block a user