From 06dbcecfad42dff2a96ff37323bd5e6135f7198b Mon Sep 17 00:00:00 2001
From: Andrey Goncharov <aigoncharov@meta.com>
Date: Tue, 25 Oct 2022 05:31:48 -0700
Subject: [PATCH] Open support request when user creates a universal export

Summary:
Design doc: https://docs.google.com/document/d/1HLCFl46RfqG0o1mSt8SWrwf_HMfOCRg_oENioc1rkvQ/ed

It does not make too much sense to have 2 different entry points to export Flipper debug data and to create a support request. It only creates ambiguity for our users. We could open the support request form automatically for them every time. In those rare cases when they try to attach new data to an existing support request, they can always not submit the form.

Reviewed By: passy

Differential Revision: D40632145

fbshipit-source-id: 6ca454d6e885493b32ac3aad008482045dccf51d
---
 .../src/sandy-chrome/LeftRail.tsx             | 40 +++----------------
 1 file changed, 5 insertions(+), 35 deletions(-)

diff --git a/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx b/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx
index b672efc9a..f14b59fd3 100644
--- a/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx
+++ b/desktop/flipper-ui-core/src/sandy-chrome/LeftRail.tsx
@@ -77,7 +77,6 @@ import {
 import {openDeeplinkDialog} from '../deeplink';
 import {css} from '@emotion/css';
 import {getRenderHostInstance} from 'flipper-frontend-core';
-import openSupportRequestForm from '../fb-stubs/openSupportRequestForm';
 import {StyleGuide} from './StyleGuide';
 import {useEffect} from 'react';
 
@@ -303,7 +302,6 @@ function ExtrasMenu() {
               </Menu.Item>
             </Menu.SubMenu>
             <Menu.Divider />
-            {config.isFBBuild ? <OpenSupportRequestMenuItem /> : null}
             <Menu.Item key="settings" onClick={() => setShowSettings(true)}>
               Settings
             </Menu.Item>
@@ -417,38 +415,6 @@ function DebugLogsButton({
   );
 }
 
-function OpenSupportRequestMenuItem() {
-  const store = useStore();
-
-  const [status, setStatus] = useState<
-    ExportEverythingEverywhereAllAtOnceStatus | undefined
-  >();
-
-  return (
-    <>
-      <ExportEverythingEverywhereAllAtOnceStatusModal
-        status={status}
-        setStatus={setStatus}
-      />
-      <Menu.Item
-        key="feedback"
-        onClick={async () => {
-          getLogger().track('usage', 'support-form-source', {
-            source: 'sidebar',
-            group: undefined,
-          });
-          await exportEverythingEverywhereAllAtOnce(
-            store,
-            (...args) => setStatus(args),
-            true,
-          );
-        }}>
-        Feedback
-      </Menu.Item>
-    </>
-  );
-}
-
 function ExportEverythingEverywhereAllAtOnceStatusModal({
   status,
   setStatus,
@@ -557,7 +523,11 @@ function ExportEverythingEverywhereAllAtOnceButton() {
   const exportEverythingEverywhereAllAtOnceTracked = useTrackedCallback(
     'Debug data export',
     () =>
-      exportEverythingEverywhereAllAtOnce(store, (...args) => setStatus(args)),
+      exportEverythingEverywhereAllAtOnce(
+        store,
+        (...args) => setStatus(args),
+        config.isFBBuild,
+      ),
     [store, setStatus],
   );