Re-use base tsconfig options

Summary: Added tsconfig.base.json and extend other tsconfigs from it.

Reviewed By: passy

Differential Revision: D20594653

fbshipit-source-id: 28dd80262613e78a7c4ce25fa31f251537ec2b06

desktop/.gitignore

@@ -0,0 +1,3 @@
+lib/
+node_modules/
+*.tsbuildinfo

desktop/doctor/.gitignore

@@ -1,2 +0,0 @@
-/lib
-node_modules/

desktop/doctor/package.json

@@ -24,7 +24,7 @@
     "typescript": "^3.7.2"
   },
   "scripts": {
-    "build": "tsc",
+    "build": "tsc -b",
     "prepare": "yarn run build",
     "prepublishOnly": "yarn test && yarn run lint",
     "preversion": "yarn run lint",

desktop/doctor/tsconfig.json

@@ -1,12 +1,8 @@
 {
+  "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "lib": ["es7", "dom", "es2017"],
+    "outDir": "lib",
-    "target": "es5",
+    "rootDir": "src"
-    "module": "commonjs",
-    "declaration": true,
-    "outDir": "./lib",
-    "strict": true,
-    "skipLibCheck": true
   },
   "include": ["src"],
   "exclude": ["node_modules", "**/__tests__/*"]

desktop/pkg/.eslintignore

@@ -1 +0,0 @@
-/lib

desktop/pkg/.gitignore

@@ -1,2 +0,0 @@
-/lib
-/node_modules/

desktop/pkg/package.json

@@ -46,7 +46,7 @@
     "typescript": "^3.7.2"
   },
   "scripts": {
-    "build": "tsc",
+    "build": "tsc -b",
     "postpack": "rm -f oclif.manifest.json",
     "prepack": "rm -rf lib && tsc -b && oclif-dev manifest && oclif-dev readme",
     "prepare": "yarn run build",

desktop/pkg/tsconfig.json

@@ -1,17 +1,10 @@
 {
+  "extends": "../tsconfig.base.json",
   "compilerOptions": {
-    "target": "es2017",
-    "module": "commonjs",
-    "declaration": true,
     "outDir": "lib",
     "rootDir": "src",
-    "strict": true,
-    "importHelpers": true,
-    "esModuleInterop": true,
-    "skipLibCheck": true,
     "allowJs": true
   },
-  "include": [
+  "include": ["src"],
-    "src/**/*"
+  "exclude": ["node_modules", "**/__tests__/*"]
-  ]
 }

desktop/tsconfig.base.json

@@ -0,0 +1,16 @@
+{
+  "compilerOptions": {
+    "module": "commonjs",
+    "lib": ["es7", "dom", "es2017"],
+    "esModuleInterop": true,
+    "target": "ES2017",
+    "removeComments": true,
+    "preserveConstEnums": true,
+    "sourceMap": true,
+    "jsx": "react",
+    "moduleResolution": "node",
+    "skipLibCheck": true,
+    "strict": true,
+    "incremental": true
+  }
+}

desktop/tsconfig.json

@@ -1,25 +1,23 @@
 {
+  "extends": "./tsconfig.base.json",
   "compilerOptions": {
-    "module": "commonjs",
-    "lib": ["es7", "dom", "es2017"],
-    "esModuleInterop": true,
-    "target": "es6",
-    "removeComments": true,
-    "preserveConstEnums": true,
-    "sourceMap": true,
-    "jsx": "react",
-    "moduleResolution": "node",
     "baseUrl": ".",
-    "downlevelIteration": true,    
-    "skipLibCheck": true,
     "paths": {
       "flipper": ["./app/src"],
       "flipper-doctor": ["./doctor/src"],
       "flipper-pkg": ["./pkg/src"],
       "live-plugin-manager": ["./types/live-plugin-manager.d.tsx"]
-    },
+    }
-    "strict": true
   },
-  "include": ["src/**/*", "doctor/**/*", "pkg/**/*", "static/**/*", "scripts/**/*", "types/**/*", "headless/**/*", "plugins/**/*"],
+  "include": [
+    "src/**/*",
+    "doctor/**/*",
+    "pkg/**/*",
+    "static/**/*",
+    "scripts/**/*",
+    "types/**/*",
+    "headless/**/*",
+    "plugins/**/*"
+  ],
   "exclude": ["node_modules", "**/*.spec.ts"]
 }