jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move plugin manager logic out of UI component

Browse Source 
Summary: Moving some things around for the upcoming update support.

Reviewed By: jknoxville

Differential Revision: D18347572

fbshipit-source-id: b614fe3a87f8e7fdc0c11c0d3bfe4787c0914d17
This commit is contained in:
Pascal Hartig
2019-11-06 08:31:43 -08:00
committed by Facebook Github Bot
parent 4c0c212258
commit 05c007be16
3 changed files with 76 additions and 54 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/chrome/PluginInstaller.tsx
View File

@@ -30,7 +30,6 @@ import {List} from 'immutable';
import algoliasearch from 'algoliasearch';
import path from 'path';
import fs from 'fs-extra';
import {PluginManager as PM} from 'live-plugin-manager';
import {reportPlatformFailures, reportUsage} from '../utils/metrics';
import restartFlipper from '../utils/restartFlipper';
import {
@@ -38,17 +37,17 @@ import {
PluginDefinition,
registerInstalledPlugins,
} from '../reducers/pluginManager';
import {PLUGIN_DIR, readInstalledPlugins} from '../dispatcher/pluginManager';
import {State as AppState, Store} from '../reducers';
import {
PLUGIN_DIR,
readInstalledPlugins,
providePluginManager,
provideSearchIndex,
} from '../utils/pluginManager';
import {State as AppState} from '../reducers';
import {connect} from 'react-redux';
import {Dispatch, Action} from 'redux';
const ALGOLIA_APPLICATION_ID = 'OFCNCOG2CU';
const ALGOLIA_API_KEY = 'f54e21fa3a2a0160595bb058179bfb1e';
const TAG = 'PluginInstaller';
const PluginManager = new PM({
ignoredDependencies: ['flipper', 'react', 'react-dom', '@types/*'],
});
const EllipsisText = styled(Text)({
overflow: 'hidden',
@@ -111,10 +110,7 @@ type OwnProps = {
type Props = OwnProps & PropsFromState & DispatchFromProps;
const defaultProps: OwnProps = {
searchIndexFactory: () => {
const client = algoliasearch(ALGOLIA_APPLICATION_ID, ALGOLIA_API_KEY);
return client.initIndex('npm-search');
},
searchIndexFactory: provideSearchIndex,
autoHeight: false,
};
@@ -208,13 +204,14 @@ function InstallButton(props: {
// create empty watchman config (required by metro's file watcher)
await fs.writeFile(path.join(PLUGIN_DIR, '.watchmanconfig'), '{}');
const pluginManager = providePluginManager();
// install the plugin and all it's dependencies into node_modules
PluginManager.options.pluginsPath = path.join(
pluginManager.options.pluginsPath = path.join(
PLUGIN_DIR,
props.name,
'node_modules',
);
await PluginManager.install(props.name);
await pluginManager.install(props.name);
// move the plugin itself out of the node_modules folder
const pluginDir = path.join(