diff --git a/desktop/app/src/init.tsx b/desktop/app/src/init.tsx index 18cb9ba70..98bbd0ea6 100644 --- a/desktop/app/src/init.tsx +++ b/desktop/app/src/init.tsx @@ -123,7 +123,6 @@ async function getFlipperServer( const keytar: KeytarModule | undefined = await getKeytarModule(staticPath); const gatekeepers = getGatekeepers(environmentInfo.os.unixname); - const serverUsageEnabled = gatekeepers['flipper_desktop_use_server']; const settings = await loadSettings(); const port = 52342; /** @@ -166,66 +165,29 @@ async function getFlipperServer( await shutdown(TCPconnectionURL); } - const [homePath, tempPath, desktopPath] = await Promise.all([ - electronIpcClient.send('getPath', 'home'), - electronIpcClient.send('getPath', 'temp'), - electronIpcClient.send('getPath', 'desktop'), - ]); + console.info('flipper-server: not running/listening, start'); - const getEmbeddedServer = async () => { - const server = new FlipperServerImpl( - { - sessionId, - environmentInfo, - env: parseEnvironmentVariables(env), - gatekeepers: gatekeepers, - paths: { - appPath, - homePath, - execPath, - staticPath, - tempPath, - desktopPath, - }, - launcherSettings: await loadLauncherSettings(), - processConfig: loadProcessConfig(env), - settings, - validWebSocketOrigins: - constants.VALID_WEB_SOCKET_REQUEST_ORIGIN_PREFIXES, - }, - logger, - keytar, - ); + const {readyForIncomingConnections} = await startServer({ + staticPath, + entry: 'index.web.dev.html', + port, + }); - return server; - }; + const server = await startFlipperServer( + appPath, + staticPath, + '', + false, + keytar, + 'embedded', + environmentInfo, + ); - if (serverUsageEnabled && (!settings.server || settings.server.enabled)) { - console.info('flipper-server: not running/listening, start'); + const companionEnv = await initCompanionEnv(server); + await server.connect(); + await readyForIncomingConnections(server, companionEnv); - const {readyForIncomingConnections} = await startServer({ - staticPath, - entry: 'index.web.dev.html', - port, - }); - - const server = await startFlipperServer( - appPath, - staticPath, - '', - false, - keytar, - 'embedded', - environmentInfo, - ); - - const companionEnv = await initCompanionEnv(server); - await server.connect(); - await readyForIncomingConnections(server, companionEnv); - - return getExternalServer(TCPconnectionURL); - } - return getEmbeddedServer(); + return getExternalServer(TCPconnectionURL); } async function start() { diff --git a/desktop/flipper-server-core/src/fb-stubs/GK.tsx b/desktop/flipper-server-core/src/fb-stubs/GK.tsx index 5a621ea1d..f551582fe 100644 --- a/desktop/flipper-server-core/src/fb-stubs/GK.tsx +++ b/desktop/flipper-server-core/src/fb-stubs/GK.tsx @@ -15,7 +15,7 @@ export type GKMap = {[key: string]: boolean}; // Allow OSS users start flipper-server -const whitelistedGKs: Array = ['flipper_desktop_use_server']; +const whitelistedGKs: Array = ['']; export function loadGKs(_username: string, _gks: Array): Promise { return Promise.reject( diff --git a/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx b/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx index b8030b935..96cf0a942 100644 --- a/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx +++ b/desktop/flipper-ui-core/src/chrome/SettingsSheet.tsx @@ -131,14 +131,7 @@ class SettingsSheet extends Component { enablePluginMarketplace, enablePluginMarketplaceAutoUpdate, marketplaceURL, - server, } = this.state.updatedSettings; - - const serverUsageEnabled = getRenderHostInstance().GK( - 'flipper_desktop_use_server', - ); - const serverType = getRenderHostInstance().serverConfig.type; - const settingsPristine = isEqual(this.props.settings, this.state.updatedSettings) && isEqual(this.props.launcherSettings, this.state.updatedLauncherSettings); @@ -400,54 +393,6 @@ class SettingsSheet extends Component { /> - { - this.setState((prevState) => ({ - updatedSettings: { - ...prevState.updatedSettings, - server: {enabled: v}, - }, - })); - }}> - {serverUsageEnabled ? ( - <> - - {serverType ? ( - <> - - {serverType === 'external' ? ( - <> -
- - To stop the server, it may be necessary to kill the - process listening at port 52342. See below: - -
- sudo kill $(lsof -t -i :52342) - - ) : ( - <> - )} - - ) : ( - <> - )} - - ) : ( - - )} -
Reset all new user tooltips