jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fixed relilability issues in running health checks

Browse Source 
Summary: Run doctor checks remained pending when the socket disonnected during a check. This

Reviewed By: aigoncharov

Differential Revision: D32984539

fbshipit-source-id: 277005e78803afaaa220cc5ca7fdc9cca6254453
This commit is contained in:
Michel Weststrate
2021-12-13 05:46:42 -08:00
committed by Facebook GitHub Bot
parent 6f9983eb42
commit 0510786dec
4 changed files with 27 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/flipper-ui-browser/src/flipperServerConnection.tsx
View File

@@ -12,7 +12,7 @@ import {FlipperServer} from 'flipper-common';
import {io, Socket} from 'socket.io-client';
const CONNECTION_TIMEOUT = 30 * 1000;
const EXEC_TIMOUT = 30 * 10 * 1000;
const EXEC_TIMOUT = 30 * 1000;
export function createFlipperServer(): Promise<FlipperServer> {
// TODO: polish this all!
@@ -54,6 +54,10 @@ export function createFlipperServer(): Promise<FlipperServer> {
window?.flipperShowError?.('WebSocket connection lost');
console.warn('Socket to Flipper server disconnected');
connected = false;
pendingRequests.forEach((r) =>
r.reject(new Error('FLIPPER_SERVER_SOCKET_CONNECT_LOST')),
);
pendingRequests.clear();
});
socket.on('exec-response', (id: number, data: any) => {