Remove instanceof checks

Summary: Replaced `instanceof` checks with `isSandyPlugin` utility. That is cleaner to read and makes it easier to find places where we make exceptions for Sandy plugins

Reviewed By: jknoxville

Differential Revision: D22206707

fbshipit-source-id: b44a1b585424f3b9bf0d7ce200c34107f03ed55e

desktop/app/src/utils/pluginUtils.tsx

@@ -12,13 +12,13 @@ import {
   FlipperBasePlugin,
   PluginDefinition,
   DevicePluginDefinition,
+  isSandyPlugin,
 } from '../plugin';
 import {State as PluginStatesState} from '../reducers/pluginStates';
 import {State as PluginsState} from '../reducers/plugins';
 import {State as PluginMessageQueueState} from '../reducers/pluginMessageQueue';
 import {PluginDetails} from 'flipper-plugin-lib';
 import {deconstructPluginKey, deconstructClientId} from './clientUtils';
-import {SandyPluginDefinition} from 'flipper-plugin';
 
 type Client = import('../Client').default;
 
@@ -205,7 +205,7 @@ export function getPersistentPlugins(plugins: PluginsState): Array<string> {
       plugin == 'DeviceLogs' ||
       (pluginClass &&
         // TODO: support Sandy plugin T68683449
-        !(pluginClass instanceof SandyPluginDefinition) &&
+        !isSandyPlugin(pluginClass) &&
         (pluginClass.defaultPersistedState != undefined ||
           pluginClass.exportPersistedState != undefined))
     );