Remove instanceof checks

Summary: Replaced `instanceof` checks with `isSandyPlugin` utility. That is cleaner to read and makes it easier to find places where we make exceptions for Sandy plugins

Reviewed By: jknoxville

Differential Revision: D22206707

fbshipit-source-id: b44a1b585424f3b9bf0d7ce200c34107f03ed55e
This commit is contained in:
Michel Weststrate
2020-07-01 08:58:40 -07:00
committed by Facebook GitHub Bot
parent 1dc9e899b8
commit 04a29315e2
11 changed files with 45 additions and 34 deletions

View File

@@ -28,9 +28,8 @@ import {
defaultEnabledBackgroundPlugins,
} from '../utils/pluginUtils';
import {deconstructClientId} from '../utils/clientUtils';
import {FlipperDevicePlugin, PluginDefinition} from '../plugin';
import {FlipperDevicePlugin, PluginDefinition, isSandyPlugin} from '../plugin';
import {RegisterPluginAction} from './plugins';
import {SandyPluginDefinition} from 'flipper-plugin';
export type StaticView =
| null
@@ -438,7 +437,7 @@ export default (state: State = INITAL_STATE, action: Actions): State => {
plugins.forEach((plugin) => {
// TODO: T68738317 support sandy device plugin
if (
!(plugin instanceof SandyPluginDefinition) &&
!isSandyPlugin(plugin) &&
plugin.prototype instanceof FlipperDevicePlugin
) {
// smell: devices are mutable