Save node binary with name flipper-runtime

Summary:
As discussed with lblasa. This solves a few issues:

- Confusing names in `ps` and Activity Monitor related to Flipper.
- Permission requests for the Keychain from "node" lead users to deny it.
- Seeing "node" as allowed apps for an entry in Keychain is confusing.

Reviewed By: lblasa

Differential Revision: D50232337

fbshipit-source-id: 3bc92aae0ca31d1a80582fb8a794bbc64fc2f2e5
This commit is contained in:
Pascal Hartig
2023-10-13 03:31:11 -07:00
committed by Facebook GitHub Bot
parent 436203161d
commit 0134b66f37
2 changed files with 7 additions and 7 deletions

View File

@@ -53,14 +53,14 @@ enum BuildPlatform {
const LINUX_STARTUP_SCRIPT = `#!/bin/sh
THIS_DIR="$( cd "$( dirname "\${BASH_SOURCE[0]}" )" && pwd )"
cd "$THIS_DIR"
./node ./server "$@"
./flipper-runtime ./server "$@"
`;
const WINDOWS_STARTUP_SCRIPT = `@echo off
setlocal
set "THIS_DIR=%~dp0"
cd /d "%THIS_DIR%"
node server %*
flipper-runtime server %*
`;
const argv = yargs
@@ -697,7 +697,7 @@ async function setUpMacBundle(
'Flipper.app',
'Contents',
'MacOS',
'node',
'flipper-runtime',
);
return {resourcesPath: resourcesOutputDir, nodePath: nodeOutputPath};
}
@@ -715,7 +715,7 @@ async function bundleServerReleaseForPlatform(
await fs.mkdirp(outputDir);
let outputPaths = {
nodePath: path.join(outputDir, 'node'),
nodePath: path.join(outputDir, 'flipper-runtime'),
resourcesPath: outputDir,
};