Crash reporter plugin
Summary: This diff adds a static function `onRegisterDevice` which is being called whenever an device gets registered. This callback is used to add loglisterner for android. I even moved the logic of iOS from `onRegisterPlugin` to this callback. The reason for not adding android log listener in `onRegisterPlugin` was that there were cases when baseDevice was not yet registered before calling `onRegisterPlugin`. For android, I want the instance of `BaseDevice` so that I can add logListener on it. Reviewed By: danielbuechele Differential Revision: D13563282 fbshipit-source-id: b5be40f3dbc808bdaeabae28423c563cf2345a22
This commit is contained in:
committed by
Facebook Github Bot
parent
c6efea991d
commit
0048fc6e4a
@@ -56,26 +56,6 @@ export default (store: Store, logger: Logger) => {
|
||||
store.dispatch(addFailedPlugins(failedPlugins));
|
||||
store.dispatch(registerPlugins(initialPlugins));
|
||||
|
||||
initialPlugins.forEach(p => {
|
||||
if (p.onRegisterPlugin) {
|
||||
p.onRegisterPlugin(store, (pluginKey: string, newPluginState: any) => {
|
||||
const persistedState = getPersistedState(
|
||||
pluginKey,
|
||||
p,
|
||||
store.getState().pluginStates,
|
||||
);
|
||||
if (newPluginState && newPluginState !== persistedState) {
|
||||
store.dispatch(
|
||||
setPluginState({
|
||||
pluginKey: pluginKey,
|
||||
state: newPluginState,
|
||||
}),
|
||||
);
|
||||
}
|
||||
});
|
||||
}
|
||||
});
|
||||
|
||||
let state: ?State = null;
|
||||
store.subscribe(() => {
|
||||
const newState = store.getState().plugins;
|
||||
|
||||
Reference in New Issue
Block a user